Re: [edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe: Correct Legacy16GetTableAddress call for E820 data

2019-06-13 Thread Laszlo Ersek
s.io [mailto:devel@edk2.groups.io] On Behalf Of >>> David Woodhouse >>> Sent: Thursday, June 13, 2019 5:43 AM >>> To: Wu, Hao A >>> Cc: devel@edk2.groups.io; Ni, Ray; Justen, Jordan L; Laszlo Ersek; Ard >>> Biesheuvel >>> Subject: [edk2-devel]

Re: [edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe: Correct Legacy16GetTableAddress call for E820 data

2019-06-13 Thread David Woodhouse
t; > Sent: Thursday, June 13, 2019 5:43 AM > > To: Wu, Hao A > > Cc: devel@edk2.groups.io; Ni, Ray; Justen, Jordan L; Laszlo Ersek; Ard > > Biesheuvel > > Subject: [edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe: Correct > > Legacy16GetTableAddress call fo

Re: [edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe: Correct Legacy16GetTableAddress call for E820 data

2019-06-13 Thread David Woodhouse
On Thu, 2019-06-13 at 00:40 -0700, Jordan Justen wrote: > On 2019-06-12 23:28:12, Wu, Hao A wrote: > > > > > -Original Message- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > > David Woodhouse > > > Sent: Thursday, June 13, 2019 5:43 AM > > > > > > The DX

Re: [edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe: Correct Legacy16GetTableAddress call for E820 data

2019-06-13 Thread Jordan Justen
On 2019-06-12 23:28:12, Wu, Hao A wrote: > > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > David Woodhouse > > Sent: Thursday, June 13, 2019 5:43 AM > > > > The DX register is supposed to contain the required alignment for the > >

Re: [edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe: Correct Legacy16GetTableAddress call for E820 data

2019-06-13 Thread Ni, Ray
> -Original Message- > From: Wu, Hao A > Sent: Thursday, June 13, 2019 2:28 PM > To: devel@edk2.groups.io; dw...@infradead.org; Ni, Ray > > Cc: Justen, Jordan L ; Laszlo Ersek > ; Ard Biesheuvel > Subject: RE: [edk2-devel] [PATCH 11/10] OvmfPkg/Csm/

Re: [edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe: Correct Legacy16GetTableAddress call for E820 data

2019-06-13 Thread Wu, Hao A
ay; Justen, Jordan L; Laszlo Ersek; Ard > Biesheuvel > Subject: [edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe: Correct > Legacy16GetTableAddress call for E820 data > > The DX register is supposed to contain the required alignment for the > allocation. It was zero, and SeaB

[edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe: Correct Legacy16GetTableAddress call for E820 data

2019-06-12 Thread David Woodhouse
The DX register is supposed to contain the required alignment for the allocation. It was zero, and SeaBIOS doesn't (well, didn't) cope well with that. Set it appropriately, and set BX to indicate the regions it's OK to allocate in too. That was already OK but let's make sure it's initialised