Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/Usb/Keyboard.c: don't request protocol before setting

2021-01-27 Thread Patrick Rudolph
Hello, Until now no regressions have been observed. I'll provide a full test description using a wide variety of platforms soon. Kind Regards, Patrick Rudolph On Thu, Jan 28, 2021 at 3:14 AM Wu, Hao A wrote: > > > -Original Message- > > From: Patrick Rudolph > > Sent: Wednesday, January

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/Usb/Keyboard.c: don't request protocol before setting

2021-01-27 Thread Wu, Hao A
> -Original Message- > From: Patrick Rudolph > Sent: Wednesday, January 20, 2021 11:59 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray > Subject: [PATCH 2/2] MdeModulePkg/Usb/Keyboard.c: don't request > protocol before setting > > From: Matt DeVillier > > No ne

[edk2-devel] [PATCH 2/2] MdeModulePkg/Usb/Keyboard.c: don't request protocol before setting

2021-01-20 Thread Patrick Rudolph
From: Matt DeVillier No need to check the interface protocol then conditionally setting, just set it to BOOT_PROTOCOL and check for error. This is what Linux does for HID devices as some don't follow the USB spec. One example is the Aspeed BMC HID keyboard device, which adds a massive boot delay