Re: [edk2-devel] [PATCH 2/2] Platform/Intel: Cleanup temporary build workaround related code

2020-04-23 Thread Heng Luo
Hi Eric, OK, I will combine them into one patch. Thanks, Heng > -Original Message- > From: Dong, Eric > Sent: Friday, April 24, 2020 8:52 AM > To: Luo, Heng ; devel@edk2.groups.io > Cc: Michael Kubacki ; Gao, Liming > ; Ni, Ray > Subject: RE: [PATCH 2/2] Platform/Intel: Cleanup

Re: [edk2-devel] [PATCH 2/2] Platform/Intel: Cleanup temporary build workaround related code

2020-04-23 Thread Dong, Eric
Hi Heng, You can't separate these two patches like this. Because in this case, the first patch will cause all platforms which use AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc file build error. Please reorg the patches to make all patches can pass build for all

Re: [edk2-devel] [PATCH 2/2] Platform/Intel: Cleanup temporary build workaround related code

2020-04-23 Thread Michael Kubacki
Reviewed-by: Michael Kubacki On 4/23/2020 1:42 AM, Heng Luo wrote: Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2688 Use AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc instead of AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc Cc: Michael Kubacki Cc:

[edk2-devel] [PATCH 2/2] Platform/Intel: Cleanup temporary build workaround related code

2020-04-23 Thread Heng Luo
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2688 Use AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc instead of AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.dsc Cc: Michael Kubacki Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Signed-off-by: Heng Luo ---