Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling

2023-03-21 Thread Ni, Ray
Just found "if (!Buffer)" doesn't follow EDK2 coding style. I changed to "if (Buffer == NULL) {" in final merge PR. > -Original Message- > From: Gerd Hoffmann > Sent: Friday, March 10, 2023 8:49 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Oliver Steffen ; > Gerd Hoffmann ; Kumar, Rahul

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling

2023-03-20 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Gerd Hoffmann > Sent: Friday, March 10, 2023 8:49 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Oliver Steffen ; Gerd > Hoffmann ; Kumar, Rahul R > ; Pawel Polawski ; > Dong, Eric > Subject: [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: fix

[edk2-devel] [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling

2023-03-10 Thread Gerd Hoffmann
ASSERT() is not proper handling of allocation failures, it gets compiled out on RELEASE builds. Print a message and enter dead loop instead. Signed-off-by: Gerd Hoffmann --- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git