Re: [edk2-devel] [PATCH 2/3] ArmPlatformPkg: PrePeiCore: write early hello message to the serial port

2022-08-04 Thread Ard Biesheuvel
On Thu, 28 Jul 2022 at 11:53, Oliver Steffen wrote: > > Hi everyone, > > I checked Rebecca's patch with my Qemu use case. > All fine - we can use that patch instead of the series I posted here. > Even better, because it prints the version information. > > Thanks! > Thanks for confirming. -=-=-=

Re: [edk2-devel] [PATCH 2/3] ArmPlatformPkg: PrePeiCore: write early hello message to the serial port

2022-07-28 Thread Oliver Steffen
Hi everyone, I checked Rebecca's patch with my Qemu use case. All fine - we can use that patch instead of the series I posted here. Even better, because it prints the version information. Thanks! Regards, Oliver On Tue, Jul 26, 2022 at 6:22 PM Sami Mujawar wrote: > Hi Oliver, > > > > Both yo

Re: [edk2-devel] [PATCH 2/3] ArmPlatformPkg: PrePeiCore: write early hello message to the serial port

2022-07-26 Thread Sami Mujawar
Hi Oliver, Both your and Rebecca’s patches are using SerialPortWrite() which should work regardless of the debug print level and for release builds as well. Rebecca’s patch additionally initialises the serial port which is required if the UART has not been setup by any previous firmware. I belie

Re: [edk2-devel] [PATCH 2/3] ArmPlatformPkg: PrePeiCore: write early hello message to the serial port

2022-07-26 Thread Oliver Steffen
Hi Sami, Thank you for pointing to that patch. It pretty much does the same thing and I would be OK with using it instead of these changes here. Except that the message only shows up in debug mode and seems to depend on the debug mask. It would be nice if it would show up all the time. We are bui

Re: [edk2-devel] [PATCH 2/3] ArmPlatformPkg: PrePeiCore: write early hello message to the serial port

2022-07-26 Thread Sami Mujawar
Hi Oliver, There is a patch for review at https://edk2.groups.io/g/devel/message/4 which prints the firmware version string. I believe with Ard's comments addressed that patch can be merged. Would that patch solve your purpose to print an early message for debug purpose? Regards, Sami Muja

[edk2-devel] [PATCH 2/3] ArmPlatformPkg: PrePeiCore: write early hello message to the serial port

2022-07-26 Thread Oliver Steffen
From: Laszlo Ersek Print the early hello message to the serial port. The FixedPcdGetSize() macro expands to an integer constant, therefore an optimizing compiler can eliminate the new code, if the platform DSC doesn't override the empty string (size=1) default of PcdEarlyHelloMessage. Signed-of