.
Thanks,
Ray
From: Sean Rhodes
Sent: Monday, March 20, 2023 8:47 PM
To: Ni, Ray
Cc: Tan, Lean Sheng ; devel@edk2.groups.io; Kinney,
Michael D ; Gao, Zhichao ;
Wang, Jian J ; Gao, Liming
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control
the position of the Logo
Hi
gt;
>
> Perhaps a single PCD that is a enum of logo locations. Default 0x00 can
> be EDK II default that is centered in the display. 0x01 can be BGRT.
> Leaves from for more if there are additional public standard logo locations.
>
>
>
> Mike
>
>
>
>
>
> *Fr
0, 2023 4:12 PM
To: devel@edk2.groups.io; Ni, Ray ; Kinney, Michael D
Cc: Rhodes, Sean ; Gao, Zhichao ;
Wang, Jian J ; Gao, Liming
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control
the position of the Logo
Hi Ray,
Any feedback per Mic feedback?
On 15. Mar 2023, at 1
tems>
Cc: Gao, Zhichao <zhichao@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo
Are you suggesting that the exiting logic be updated
From: Ni, Ray
Sent: Wednesday, March 15, 2023 2:24 AM
To: devel@edk2.groups.io; Rhodes, Sean
Cc: Kinney, Michael D ; Gao, Zhichao
; Wang, Jian J ; Gao, Liming
Subject: RE: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control
the position of the Logo
What’s the meaning of “have both
.groups.io; Kinney, Michael D ; Gao,
Zhichao ; Wang, Jian J ; Gao,
Liming
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control
the position of the Logo
Hi Ray
> You can return a carefully-calculated X/Y value to make the
> logo at MS preferred position.
devel@edk2.groups.io; Rhodes, Sean
Cc: Gao, Zhichao <zhichao@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo
Are you sugge
evel@edk2.groups.io * On Behalf Of *Ni,
>> Ray
>> *Sent:* Wednesday, October 26, 2022 10:32 AM
>> *To:* Kinney, Michael D ;
>> devel@edk2.groups.io; Rhodes, Sean
>> *Cc:* Gao, Zhichao ; Wang, Jian J <
>> jian.j.w...@intel.com>; Gao, Liming
>> *Sub
*Ni,
> Ray
> *Sent:* Wednesday, October 26, 2022 10:32 AM
> *To:* Kinney, Michael D ; devel@edk2.groups.io;
> Rhodes, Sean
> *Cc:* Gao, Zhichao ; Wang, Jian J <
> jian.j.w...@intel.com>; Gao, Liming
> *Subject:* Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a
Sent: Wednesday, October 26, 2022 10:32 AM
To: Kinney, Michael D ; devel@edk2.groups.io;
Rhodes, Sean
Cc: Gao, Zhichao ; Wang, Jian J ;
Gao, Liming
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control
the position of the Logo
Are you suggesting that the exiting logic
1:30 PM
To: Kinney, Michael D
Cc: Ni, Ray ; devel@edk2.groups.io; Gao, Zhichao
; Wang, Jian J ; Gao, Liming
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control
the position of the Logo
Hi Mike
This patch is being upstreamed from the coreboot fork; about 70
nney, Michael D ; devel@edk2.groups.io;
> Rhodes, Sean
> *Cc:* Gao, Zhichao ; Wang, Jian J <
> jian.j.w...@intel.com>; Gao, Liming
> *Subject:* RE: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to
> control the position of the Logo
>
>
>
> Are you suggestin
: Gao, Zhichao ; Wang, Jian J ;
Gao, Liming
Subject: RE: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control
the position of the Logo
Are you suggesting that the exiting logic be updated for this use case without
adding a new enum?
* yes.
From: Kinney, Michael D
Subject: RE: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control
the position of the Logo
Ray,
Are you suggesting that the exiting logic be updated for this use case without
adding a new enum?
Sean, can you provide a revised patch that does this?
Thanks,
Mike
From: devel@edk2
Hi Mike/Ray
Thanks - so you mean something like
https://github.com/tianocore/edk2/pull/3528? (
https://github.com/tianocore/edk2/pull/3528 ) (Just for example)
If not, I'm not sure how to control it without the PCD?
Sean
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent
, Sean
Cc: Gao, Zhichao ; Wang, Jian J ;
Gao, Liming
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control
the position of the Logo
I need a reason of adding EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended.
In my opinion, without adding this new enum value, it’s
: devel@edk2.groups.io; Gao, Zhichao ; Wang, Jian J
; Gao, Liming
Subject: Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control
the position of the Logo
Hi Ray
Where would you suggest this code goes? edk2 should support both Microsoft
recommended and "normal". The orig
Hi Ray
Where would you suggest this code goes? edk2 should support both Microsoft
recommended and "normal". The original patch handled this well.
Thanks
Sean
On Mon, 10 Oct 2022 at 10:25, Ni, Ray wrote:
> The logic I shared below is from the LogoDxe driver which produces
>
+ Matt
@Matt DeVillier Does Ray's code work for you?
On Mon, 10 Oct 2022 at 10:25, Ni, Ray wrote:
> The logic I shared below is from the LogoDxe driver which produces
> EDKII_PLATFORM_LOGO_PROTOCOL.
>
> This driver should know the image size and it can account for the image
> size.
>
>
>
>
The logic I shared below is from the LogoDxe driver which produces
EDKII_PLATFORM_LOGO_PROTOCOL.
This driver should know the image size and it can account for the image size.
Thanks,
Ray
From: Sean Rhodes
Sent: Monday, October 10, 2022 4:51 PM
To: Ni, Ray
Cc: devel@edk2.groups.io; Gao,
Hi Ray
Thank you, it does, and I think it will work for most splash images.
However, the way it's written in my patch accounts for the Image size. This
will handle splash images that are equal to, or larger than the resolution
of the display.
Thanks
Sean
On Sat, 8 Oct 2022 at 03:02, Ni, Ray
Sean,
I remember that I evaluated the BGRT requirement when designing the
PlatformLogo protocol.
So, I went back to got the code I wrote long time ago as below.
I didn't try to understand them now. Does it make sense to you?
Status = gBS->HandleProtocol (gST->ConsoleOutHandle,
, (VOID **)
When set to true, the Logo is positioned according to the BGRT
specification, 38.2% from the top of the screen. When set to false,
no behaviour is changed and the logo is positioned centrally.
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Sean Rhodes
---
When set to true, the Logo is positioned according to the BGRT
specification, 38.2% from the top of the screen. When set to false,
no behaviour is changed and the logo is positioned centrally.
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Sean Rhodes
---
When set to true, the Logo is positioned according to the BGRT
specification, 38.2% from the top of the screen. When set to false,
no behaviour is changed and the logo is positioned centrally.
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Sean Rhodes
---
25 matches
Mail list logo
