Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

2019-07-16 Thread Laszlo Ersek
On 07/16/19 12:05, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 7/2/19 12:28 PM, Laszlo Ersek wrote: >> Rewrite Base64Decode() from scratch, due to reasons listed in the second >> reference below. >> >> Implement Base64Decode() according to the specification added in the >> previous patch.

Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

2019-07-16 Thread Laszlo Ersek
>> Marvin Häuser ; Philippe Mathieu-Daudé >> >> Subject: Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite >> Base64Decode() >> >> On 07/15/19 17:22, Gao, Liming wrote: >>> Laszlo: >>> >>>> -Original Message- >>>&

Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

2019-07-16 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 7/2/19 12:28 PM, Laszlo Ersek wrote: > Rewrite Base64Decode() from scratch, due to reasons listed in the second > reference below. > > Implement Base64Decode() according to the specification added in the > previous patch. The decoder scans the input buffer once, it has no inner >

Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

2019-07-15 Thread Gao, Zhichao
; Sent: Saturday, July 13, 2019 3:31 AM > >> To: Gao, Zhichao ; devel@edk2.groups.io; Gao, > >> Liming ; Kinney, Michael D > >> > >> Cc: Marvin Häuser ; Philippe Mathieu-Daudé > >> > >> Subject: Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: re

Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

2019-07-15 Thread Laszlo Ersek
Hi Marvin, On 07/15/19 20:44, Marvin Häuser wrote: > I feel like my rushed message mentioning 'MAX_ADDRESS' was misleading > a little - the point with that was a potential index overflow (I may > actually have meant 'MAX_UINTN', I am not sure about the details > anymore) in the original code, I

Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

2019-07-15 Thread Laszlo Ersek
Gao, Liming >> ; Kinney, Michael D >> >> Cc: Marvin Häuser ; Philippe Mathieu-Daudé >> >> Subject: Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode() >> >> On 07/12/19 04:31, Gao, Zhichao wrote: >>> Sorry for late respond. >>

Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

2019-07-15 Thread Marvin Häuser
; > Philippe Mathieu-Daudé ; Zhichao Gao > > Subject: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode() > > Rewrite Base64Decode() from scratch, due to reasons listed in the second > reference below. > > Implement Base64Decode() according to the specificati

Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

2019-07-15 Thread Liming Gao
; Philippe Mathieu-Daudé > > Subject: Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode() > > On 07/12/19 04:31, Gao, Zhichao wrote: > > Sorry for late respond. > > The whole code is OK for me. And I write a tiny test for it without the > > memory address

Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

2019-07-12 Thread Laszlo Ersek
; >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Laszlo Ersek >> Sent: Tuesday, July 2, 2019 6:29 PM >> To: edk2-devel-groups-io >> Cc: Gao, Liming ; Marvin Häuser >> ; Kinney, Michael D ; &

Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

2019-07-11 Thread Gao, Zhichao
zlo Ersek > Sent: Tuesday, July 2, 2019 6:29 PM > To: edk2-devel-groups-io > Cc: Gao, Liming ; Marvin Häuser > ; Kinney, Michael D ; > Philippe Mathieu-Daudé ; Gao, Zhichao > > Subject: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode() > > Rewrite Base64D

[edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

2019-07-02 Thread Laszlo Ersek
Rewrite Base64Decode() from scratch, due to reasons listed in the second reference below. Implement Base64Decode() according to the specification added in the previous patch. The decoder scans the input buffer once, it has no inner loop(s), and it spills each output byte as soon as the output