Re: [edk2-devel] [PATCH 2/3] UefiCpuPkg/PiSmmCpu: Refine CR2 save/restore logic

2019-07-29 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Saturday, July 27, 2019 11:29 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek ; > Vanguput, Narendra K > Subject: [PATCH 2/3] UefiCpuPkg/PiSmmCpu: Refine CR2 save/restore logic > > Because

Re: [edk2-devel] [PATCH 2/3] UefiCpuPkg/PiSmmCpu: Refine CR2 save/restore logic

2019-07-29 Thread Laszlo Ersek
On 07/27/19 05:28, Ni, Ray wrote: > Because IsStaticPageTableEnabled() is added for both IA32 and x64 > build, the CR2 save/restore logic can be refined: > 1. Remove arch specific SaveCr2() / RestoreCr2() implementation; > 2. Conditionally save and restore CR2 in SmiRendezvous(). > >

[edk2-devel] [PATCH 2/3] UefiCpuPkg/PiSmmCpu: Refine CR2 save/restore logic

2019-07-26 Thread Ni, Ray
Because IsStaticPageTableEnabled() is added for both IA32 and x64 build, the CR2 save/restore logic can be refined: 1. Remove arch specific SaveCr2() / RestoreCr2() implementation; 2. Conditionally save and restore CR2 in SmiRendezvous(). Signed-off-by: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek