Re: [edk2-devel] [PATCH 20/35] NetworkPkg/Ip4Dxe: fix NetLibDestroyServiceChild() call

2019-09-26 Thread Siyuan, Fu
Reviewed-by: Siyuan Fu > -Original Message- > From: Philippe Mathieu-Daudé > Sent: 2019年9月24日 0:04 > To: devel@edk2.groups.io; ler...@redhat.com > Cc: Wu, Jiaxin ; Fu, Siyuan > Subject: Re: [edk2-devel] [PATCH 20/35] NetworkPkg/Ip4Dxe: fix > NetLibDestroyServiceC

Re: [edk2-devel] [PATCH 20/35] NetworkPkg/Ip4Dxe: fix NetLibDestroyServiceChild() call

2019-09-26 Thread Laszlo Ersek
Jiaxin, Siyuan, can you please review this patch? Thanks Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > Both NetLibDestroyServiceChild() and EFI_SERVICE_BINDING_DESTROY_CHILD > take an EFI_HANDLE for the "ChildHandle" parameter, not an (EFI_HANDLE*). > > This patch fixes a real bug. > > Cc:

Re: [edk2-devel] [PATCH 20/35] NetworkPkg/Ip4Dxe: fix NetLibDestroyServiceChild() call

2019-09-23 Thread Philippe Mathieu-Daudé
On 9/17/19 9:49 PM, Laszlo Ersek wrote: > Both NetLibDestroyServiceChild() and EFI_SERVICE_BINDING_DESTROY_CHILD > take an EFI_HANDLE for the "ChildHandle" parameter, not an (EFI_HANDLE*). > > This patch fixes a real bug. > > Cc: Jiaxin Wu > Cc: Siyuan Fu > Signed-off-by: Laszlo Ersek > --- >

[edk2-devel] [PATCH 20/35] NetworkPkg/Ip4Dxe: fix NetLibDestroyServiceChild() call

2019-09-17 Thread Laszlo Ersek
Both NetLibDestroyServiceChild() and EFI_SERVICE_BINDING_DESTROY_CHILD take an EFI_HANDLE for the "ChildHandle" parameter, not an (EFI_HANDLE*). This patch fixes a real bug. Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Laszlo Ersek --- Notes: possibly only build-tested