Re: [edk2-devel] [PATCH 23/35] OvmfPkg/VirtioNetDxe: fix SignalEvent() call

2019-09-26 Thread Ard Biesheuvel
On Tue, 17 Sep 2019 at 21:50, Laszlo Ersek wrote: > > The SignalEvent() boot service takes an EFI_EVENT, not an (EFI_EVENT*). > Fix the call in the notification function of > "EFI_SIMPLE_NETWORK_PROTOCOL.WaitForPacket". > > This is an actual bug. The reason it's never been triggered is likely

Re: [edk2-devel] [PATCH 23/35] OvmfPkg/VirtioNetDxe: fix SignalEvent() call

2019-09-26 Thread Laszlo Ersek
Jordan, Ard, may I please get an R-b for this patch? It's quite simple. (Sorry if it's already in your queue.) Thank you, Laszlo On 09/17/19 21:49, Laszlo Ersek wrote: > The SignalEvent() boot service takes an EFI_EVENT, not an (EFI_EVENT*). > Fix the call in the notification function of >

Re: [edk2-devel] [PATCH 23/35] OvmfPkg/VirtioNetDxe: fix SignalEvent() call

2019-09-20 Thread Philippe Mathieu-Daudé
On 9/17/19 9:49 PM, Laszlo Ersek wrote: > The SignalEvent() boot service takes an EFI_EVENT, not an (EFI_EVENT*). > Fix the call in the notification function of > "EFI_SIMPLE_NETWORK_PROTOCOL.WaitForPacket". > > This is an actual bug. The reason it's never been triggered is likely that > the

[edk2-devel] [PATCH 23/35] OvmfPkg/VirtioNetDxe: fix SignalEvent() call

2019-09-17 Thread Laszlo Ersek
The SignalEvent() boot service takes an EFI_EVENT, not an (EFI_EVENT*). Fix the call in the notification function of "EFI_SIMPLE_NETWORK_PROTOCOL.WaitForPacket". This is an actual bug. The reason it's never been triggered is likely that the "SNP.WaitForPacket" event is rarely waited for by