Re: [edk2-devel] [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0

2021-07-28 Thread Digant H Solanki
Thanks for review and suggestion, Sai..!! -Original Message- From: Chaganty, Rangasai V Sent: Wednesday, July 28, 2021 11:24 PM To: Solanki, Digant H ; devel@edk2.groups.io Cc: Ni, Ray ; S, Ashraf Ali Subject: RE: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD

Re: [edk2-devel] [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0

2021-07-28 Thread Chaganty, Rangasai V
Digant, The notation "PATCH 3/3" indicates part 3 of a 3 patch series. However since this is a single patch, the subject line could simply indicate [PATCH v3]. Something to consider for future reviews. Thanks, Sai -Original Message- From: Chaganty, Rangasai V Sent: Wednesday, July

Re: [edk2-devel] [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0

2021-07-28 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Solanki, Digant H Sent: Thursday, July 22, 2021 4:47 AM To: devel@edk2.groups.io Cc: Solanki, Digant H ; Ni, Ray ; Chaganty, Rangasai V ; S, Ashraf Ali Subject: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD

Re: [edk2-devel] [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0

2021-07-28 Thread Digant H Solanki
Please help review this patch to make it official soon. Thanks..!! -Original Message- From: Solanki, Digant H Sent: Friday, July 23, 2021 7:25 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; S, Ashraf Ali Subject: RE: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to

Re: [edk2-devel] [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0

2021-07-23 Thread Digant H Solanki
Gentle reminder to review this patch pls. Thanks..!! -Original Message- From: Solanki, Digant H Sent: Thursday, July 22, 2021 5:17 PM To: devel@edk2.groups.io Cc: Solanki, Digant H ; Ni, Ray ; Chaganty, Rangasai V ; S, Ashraf Ali Subject: [PATCH 3/3] IntelSiliconPkg: Add

[edk2-devel] [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0

2021-07-22 Thread Digant H Solanki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3426 - There are many OpRegion fields obsoleted in MBOX1 - MBOX2 is re-purposed for Backlight related fields for dual LFP. - Backlight related fields moved to MBOX2 from MBOX3 and some fields are obsoleted in MBOX3. Signed-off-by: Digant H