Sorry for my late response.
> Do we need pack(1) for this structure? We can remove pack directive if we
> don't
> need to have packed structure members. @nick...@nvidia.com, could you
> please confirm this?
I see the use of "pack(1)" in EDK2 DriverSample.h. I think we can keep it.
Reviewed-by
[AMD Official Use Only - General]
That makes sense.
Reviewed-by: Abner Chang
> -Original Message-
> From: Mike Maslenkin
> Sent: Saturday, September 30, 2023 5:59 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [PATCH 8
On Mon, Oct 2, 2023 at 5:45 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> > -Original Message-
> > From: Mike Maslenkin
> > Sent: Saturday, September 30, 2023 5:59 AM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner ; nick...@nvidia.com;
> > ig...@ami.com; Mike Maslenk
[AMD Official Use Only - General]
> -Original Message-
> From: Mike Maslenkin
> Sent: Saturday, September 30, 2023 5:59 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; nick...@nvidia.com;
> ig...@ami.com; Mike Maslenkin
> Subject: [PATCH 8/9] RedfishClientPkg: fix pragma pack usage
>
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h
b/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h
index 7e1b