Re: [edk2-devel] [PATCH V2 2/6] UefiCpuPkg/CpuSmm: Add perf-logging for MP procedures

2023-06-11 Thread Ni, Ray
> > Could we add the comments to this enum? It defines the ID of the MP procedure. > For MP procedure, it needs call SMM_MP_PERF_PROCEDURE_ID with entries > name defined in the SMM_MP_PERF_PROCEDURE_LIST. Thanks. Will add the comments. > > > > Others good to me. > > Reviewed-by: Jiaxin Wu

Re: [edk2-devel] [PATCH V2 2/6] UefiCpuPkg/CpuSmm: Add perf-logging for MP procedures

2023-06-09 Thread Wu, Jiaxin
> +// > > +// The list of all MP procedures that need to be perf-logged. > > +// > > +#define SMM_MP_PERF_PROCEDURE_LIST(_) \ > > + _(SmmInitHandler), \ > > + _(SmmRendezvousEntry), \ > > + _(PlatformValidSmi), \ > > + _(SmmRendezvousExit), \ > > + _(SmmMpProcedureMax) // Add new entr

[edk2-devel] [PATCH V2 2/6] UefiCpuPkg/CpuSmm: Add perf-logging for MP procedures

2023-05-31 Thread Ni, Ray
MP procedures are those procedures that run in every CPU thread. The EDKII perf infra is not MP safe so it doesn't support to be called from those MP procedures. The patch adds SMM MP perf-logging support in SmmMpPerf.c. The following procedures are perf-logged: * SmmInitHandler * SmmCpuFeaturesRe