Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-07 Thread Wu, Hao A
Inline replies below: > -Original Message- > From: Kubacki, Michael A > Sent: Friday, October 04, 2019 5:54 AM > To: Wu, Hao A; devel@edk2.groups.io > Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney, > Michael D; Ni, Ray; Wang, Jian J; Yao, Jiewen > Subject:

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-04 Thread Kubacki, Michael A
> On 10/03/19 23:53, Kubacki, Michael A wrote: > > #1 - The plan is to remove the polling entirely in V3. > > > > #2 - I'd prefer to take a definitive direction and reduce validation and > maintenance > > effort but you and Laszlo both requested this so I'll add a > > FeaturePCD > to

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-04 Thread Kubacki, Michael A
> On 10/04/19 01:31, Kubacki, Michael A wrote: > > I agree, I will make the default to enable the runtime cache. > > I've just made a request for the opposite :) , before reading this part > of the thread. > > Let me revise my request then, seeing the above preference. From the > following three

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-04 Thread Laszlo Ersek
On 10/04/19 01:31, Kubacki, Michael A wrote: > I agree, I will make the default to enable the runtime cache. I've just made a request for the opposite :) , before reading this part of the thread. Let me revise my request then, seeing the above preference. From the following three options: (1)

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-04 Thread Laszlo Ersek
On 10/03/19 23:53, Kubacki, Michael A wrote: > #1 - The plan is to remove the polling entirely in V3. > > #2 - I'd prefer to take a definitive direction and reduce validation and > maintenance > effort but you and Laszlo both requested this so I'll add a > FeaturePCD to control >

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-03 Thread Kubacki, Michael A
I agree, I will make the default to enable the runtime cache. > -Original Message- > From: Kinney, Michael D > Sent: Thursday, October 3, 2019 3:01 PM > To: Kubacki, Michael A ; Wu, Hao A > ; devel@edk2.groups.io; Kinney, Michael D > > Cc: Bi, Dandan ; Ard Biesheuvel > ; Dong, Eric ;

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-03 Thread Michael D Kinney
Michael, Perhaps the FeaturePCD for #2 should be enabled by default so the platform DSC only needs to set this PCD for some validation tests. Mike > -Original Message- > From: Kubacki, Michael A > Sent: Thursday, October 3, 2019 2:54 PM > To: Wu, Hao A ; devel@edk2.groups.io > Cc: Bi,

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-03 Thread Kubacki, Michael A
#1 - The plan is to remove the polling entirely in V3. #2 - I'd prefer to take a definitive direction and reduce validation and maintenance effort but you and Laszlo both requested this so I'll add a FeaturePCD to control activation of the runtime cache in this patch series.

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-03 Thread Kubacki, Michael A
I understand the concern. I'm aware code is sometimes marked as runtime compatible though it is actually not and meeting all the criteria to work in the runtime environment is non-trivial as you noted. In response to series #2 patch #8, Andrew noted that the UEFI spec defines restrictions on

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-03 Thread Laszlo Ersek
On 10/03/19 10:04, Wu, Hao A wrote: > Before any comment on the patch, since I am not experienced in the Variable > driver, I would like to ask for help from other reviewers to look into this > patch and provide feedbacks as well. Thanks in advance. > > With the above fact, some comments provided

[edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-09-27 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220 This change reduces SMIs for GetVariable () by maintaining a UEFI variable cache in Runtime DXE in addition to the pre- existing cache in SMRAM. When the Runtime Service GetVariable() is invoked, a Runtime DXE cache is used instead of