Re: [edk2-devel] [PATCH V3 3/8] CryptoPkg/BaseCryptLib: Retire ARC4 algorithm

2020-05-08 Thread Wang, Jian J
Zhichao, Thanks for making this patch series. Just two comments for patch 3: (1) If possible, please group patch file based on module unit. For this patch, I think at least OpensslLib can be put in separate patch file. (2) Please update process_files.pl in OpensslLib to generate

[edk2-devel] [PATCH V3 3/8] CryptoPkg/BaseCryptLib: Retire ARC4 algorithm

2020-05-06 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898 ARC4 is not secure any longer. Remove the ARC4 support from edk2. Change the ARC4 field name in EDKII_CRYPTO_PROTOCOL to indicate the function is unsupported any longer. Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Siyuan Fu Cc: Michael D Kinney