Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-06-03 Thread Laszlo Ersek
On 06/03/20 13:44, Leif Lindholm wrote: > On Tue, Jun 02, 2020 at 18:20:26 +0200, Laszlo Ersek wrote: >> On 06/02/20 16:20, Leif Lindholm wrote: >>> On Tue, Jun 02, 2020 at 15:29:55 +0200, Laszlo Ersek wrote: I have not been aware of the header name collision scenario (nor that the

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-06-03 Thread Leif Lindholm
On Tue, Jun 02, 2020 at 18:20:26 +0200, Laszlo Ersek wrote: > On 06/02/20 16:20, Leif Lindholm wrote: > > On Tue, Jun 02, 2020 at 15:29:55 +0200, Laszlo Ersek wrote: > >> I have not been aware of the header name collision scenario (nor that > >> the [Packages] ordering was supposed to work around

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-06-02 Thread Andrew Fish via groups.io
> On Jun 2, 2020, at 8:33 PM, Andrew Fish via groups.io > wrote: > > > >> On May 29, 2020, at 7:02 AM, Leif Lindholm wrote: >> >> The description of [Packages] sections stated that >> "Packages must be listed in the order that may be required for specifying >> include path statements for

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-06-02 Thread Andrew Fish via groups.io
> On May 29, 2020, at 7:02 AM, Leif Lindholm wrote: > > The description of [Packages] sections stated that > "Packages must be listed in the order that may be required for specifying > include path statements for a compiler. For example, the > MdePkg/MdePkg.dec file must be listed before the

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-06-02 Thread Pankaj Bansal
> >> > >> (since I've been copied) > >> > >> I have not been aware of the header name collision scenario (nor that > >> the [Packages] ordering was supposed to work around such issues). > >> > >> I work strictly with edk2 proper, where a name collision like this can > >> be detected, and so should

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-06-02 Thread Laszlo Ersek
On 06/02/20 16:20, Leif Lindholm wrote: > On Tue, Jun 02, 2020 at 15:29:55 +0200, Laszlo Ersek wrote: >> I have not been aware of the header name collision scenario (nor that >> the [Packages] ordering was supposed to work around such issues). > > Nor had I... > >> I work strictly with edk2

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-06-02 Thread Laszlo Ersek
nsal (OSS) >> >> Subject: Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on >> package ordering >> >> On 06/01/20 00:43, Leif Lindholm wrote: >>> Hi Mike, >>> >>> Ok, I'm happy to hear that. >>> >>> I agree that the

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-06-02 Thread Leif Lindholm
Hi Pankaj, On Tue, Jun 02, 2020 at 13:37:30 +, Pankaj Bansal (OSS) wrote: > > How about replacing > > > > """ > > Packages must be listed in the order that may be required for specifying > > include path statements for a compiler. For example, the MdePkg/MdePkg.dec_ > > file must be listed

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-06-02 Thread Leif Lindholm
On Tue, Jun 02, 2020 at 15:29:55 +0200, Laszlo Ersek wrote: > I have not been aware of the header name collision scenario (nor that > the [Packages] ordering was supposed to work around such issues). Nor had I... > I work strictly with edk2 proper, where a name collision like this can > be

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-06-02 Thread Pankaj Bansal
> -Original Message- > From: Laszlo Ersek > Sent: Tuesday, June 2, 2020 7:00 PM > To: Leif Lindholm ; devel@edk2.groups.io; > michael.d.kin...@intel.com > Cc: Andrew Fish ; Pankaj Bansal (OSS) > > Subject: Re: [edk2-devel] [PATCH edk2-InfSpecification] Dro

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-06-02 Thread Laszlo Ersek
On 06/01/20 00:43, Leif Lindholm wrote: > Hi Mike, > > Ok, I'm happy to hear that. > > I agree that the overriding behaviour is useful, and it would be good > to document it. The problem is that the current wording does not say > that (in a way that is useful to anyone who does not already know

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-06-01 Thread Michael D Kinney
> From: Kinney, Michael D > > Sent: Monday, June 1, 2020 10:45 AM > > To: Pankaj Bansal (OSS) ; > Leif Lindholm > > ; devel@edk2.groups.io; Kinney, > Michael D > > > > Cc: Andrew Fish ; Laszlo Ersek > > > Subject: RE: [edk2-devel] [PATCH edk2- > Inf

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-06-01 Thread Pankaj Bansal
w Fish ; Laszlo Ersek > Subject: RE: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on > package ordering > > Pankaj Bansal, > > The override package should be listed before the standard package > in the [Packages] section of an INF file. > > The internal behav

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-05-31 Thread Michael D Kinney
0 8:39 PM > To: Leif Lindholm ; > devel@edk2.groups.io; Kinney, Michael D > > Cc: Andrew Fish ; Laszlo Ersek > ; Pankaj Bansal (OSS) > > Subject: RE: [edk2-devel] [PATCH edk2-InfSpecification] > Drop statement on package ordering > > Hi Mike, > > T

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-05-31 Thread Pankaj Bansal
: Leif Lindholm > Sent: Monday, June 1, 2020 4:14 AM > To: devel@edk2.groups.io; michael.d.kin...@intel.com > Cc: Andrew Fish ; Laszlo Ersek ; Pankaj > Bansal (OSS) > Subject: Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on > package ordering > > Hi Mi

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-05-31 Thread Leif Lindholm
Hi Mike, Ok, I'm happy to hear that. I agree that the overriding behaviour is useful, and it would be good to document it. The problem is that the current wording does not say that (in a way that is useful to anyone who does not already know what it means). And the MdePkg/MdeModulePkg example

Re: [edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-05-31 Thread Michael D Kinney
Hi Leif, The reason for this statement is not for performance. It is if the same include file exists in the same path in more than one package. Defining this behavior makes the build system deterministic. There is use case where a platform package can provide an include override of a common

[edk2-devel] [PATCH edk2-InfSpecification] Drop statement on package ordering

2020-05-29 Thread Leif Lindholm
The description of [Packages] sections stated that "Packages must be listed in the order that may be required for specifying include path statements for a compiler. For example, the MdePkg/MdePkg.dec file must be listed before the MdeModulePkg/MdeModulePkg.dec file." Drop it. Signed-off-by: