Re: [edk2-devel] [PATCH edk2-platforms v2] Silicon/ChaosKeyDxe: don't rely on connect all controllers

2020-06-03 Thread Ard Biesheuvel
On 6/3/20 5:47 PM, Andrew Fish wrote: On Jun 2, 2020, at 11:32 PM, Ard Biesheuvel > wrote: On 6/3/20 12:28 AM, Andrew Fish wrote: On Jun 2, 2020, at 6:38 AM, Ard Biesheuvel mailto:ard.biesheu...@linaro.org>> wrote: From: Ard Biesheuvel

Re: [edk2-devel] [PATCH edk2-platforms v2] Silicon/ChaosKeyDxe: don't rely on connect all controllers

2020-06-03 Thread Andrew Fish via groups.io
> On Jun 2, 2020, at 11:32 PM, Ard Biesheuvel wrote: > > On 6/3/20 12:28 AM, Andrew Fish wrote: >>> On Jun 2, 2020, at 6:38 AM, Ard Biesheuvel >>> wrote: >>> >>> From: Ard Biesheuvel >>> >>> The ChaosKey driver implements the UEFI driver model, and so it is >>> not guaranteed that any

Re: [edk2-devel] [PATCH edk2-platforms v2] Silicon/ChaosKeyDxe: don't rely on connect all controllers

2020-06-03 Thread Ard Biesheuvel
On 6/3/20 12:28 AM, Andrew Fish wrote: On Jun 2, 2020, at 6:38 AM, Ard Biesheuvel wrote: From: Ard Biesheuvel The ChaosKey driver implements the UEFI driver model, and so it is not guaranteed that any controllers will be attached to this driver unless it is connected explicitly. On many

Re: [edk2-devel] [PATCH edk2-platforms v2] Silicon/ChaosKeyDxe: don't rely on connect all controllers

2020-06-02 Thread Andrew Fish via groups.io
> On Jun 2, 2020, at 6:38 AM, Ard Biesheuvel wrote: > > From: Ard Biesheuvel > > The ChaosKey driver implements the UEFI driver model, and so it is > not guaranteed that any controllers will be attached to this driver > unless it is connected explicitly. On many platforms today, this is >

Re: [edk2-devel] [PATCH edk2-platforms v2] Silicon/ChaosKeyDxe: don't rely on connect all controllers

2020-06-02 Thread Leif Lindholm
On Tue, Jun 02, 2020 at 16:58:54 +0200, Ard Biesheuvel wrote: > > > On 6/2/20 4:49 PM, Leif Lindholm wrote: > > On Tue, Jun 02, 2020 at 15:38:49 +0200, Ard Biesheuvel wrote: > > > From: Ard Biesheuvel > > > > > > The ChaosKey driver implements the UEFI driver model, and so it is > > > not

Re: [edk2-devel] [PATCH edk2-platforms v2] Silicon/ChaosKeyDxe: don't rely on connect all controllers

2020-06-02 Thread Ard Biesheuvel
On 6/2/20 4:49 PM, Leif Lindholm wrote: On Tue, Jun 02, 2020 at 15:38:49 +0200, Ard Biesheuvel wrote: From: Ard Biesheuvel The ChaosKey driver implements the UEFI driver model, and so it is not guaranteed that any controllers will be attached to this driver unless it is connected

Re: [edk2-devel] [PATCH edk2-platforms v2] Silicon/ChaosKeyDxe: don't rely on connect all controllers

2020-06-02 Thread Leif Lindholm
On Tue, Jun 02, 2020 at 15:38:49 +0200, Ard Biesheuvel wrote: > From: Ard Biesheuvel > > The ChaosKey driver implements the UEFI driver model, and so it is > not guaranteed that any controllers will be attached to this driver > unless it is connected explicitly. On many platforms today, this is

[edk2-devel] [PATCH edk2-platforms v2] Silicon/ChaosKeyDxe: don't rely on connect all controllers

2020-06-02 Thread Ard Biesheuvel
From: Ard Biesheuvel The ChaosKey driver implements the UEFI driver model, and so it is not guaranteed that any controllers will be attached to this driver unless it is connected explicitly. On many platforms today, this is taken care of by the ConnectAll() call that occurs in the BDS, but this