Re: [edk2-devel] [PATCH edk2-platforms v2 3/3] IpmiFeaturePkg: refine GetSelfTest function

2023-03-09 Thread Arun K via groups.io
We are not updating the BMC status in the switch()( *default case* ), which may lead to installing the IPMI protocol for the failure case too. Could you please initialize the BMC status in the default case also? switch ( SelfTestResult->Result ) { case IPMI_APP_SELFTEST_NO_ERROR: case

[edk2-devel] [PATCH edk2-platforms v2 3/3] IpmiFeaturePkg: refine GetSelfTest function

2023-03-08 Thread Mike Maslenkin
Use predefined type while accessing IPMI command returned data instead of raw byte array. Signed-off-by: Mike Maslenkin Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao --- .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-)