Hi Pankaj,
On Fri, May 08, 2020 at 05:31:53 +, Pankaj Bansal (OSS) wrote:
> > > > > - {
> > > > > -Found = TRUE;
> > > > > -break;
> > > > > - }
> > > > > - NextHob.Raw = GET_NEXT_HOB (NextHob);
> > > > > + Status = GetDramRegionsInfo (DramRegions, ARRAY_SIZE
>
>
> On Thu, May 07, 2020 at 07:28:30 +, Pankaj Bansal (OSS) wrote:
> > Hi Leif,
> >
> > > > + ARM_SMC_ARGS ArmSmcArgs;
> > > >
> > > > -Routine Description:
> > > > + ArmSmcArgs.Arg0 = SMC_DRAM_BANK_INFO;
> > > > + ArmSmcArgs.Arg1 = -1;
> > >
> > > Should this be SMC_UNK?
> >
> > No. SMC_O
On Thu, May 07, 2020 at 07:28:30 +, Pankaj Bansal (OSS) wrote:
> Hi Leif,
>
> > > + ARM_SMC_ARGS ArmSmcArgs;
> > >
> > > -Routine Description:
> > > + ArmSmcArgs.Arg0 = SMC_DRAM_BANK_INFO;
> > > + ArmSmcArgs.Arg1 = -1;
> >
> > Should this be SMC_UNK?
>
> No. SMC_OK / SMC_UNK is returned
Hi Leif,
> > + ARM_SMC_ARGS ArmSmcArgs;
> >
> > -Routine Description:
> > + ArmSmcArgs.Arg0 = SMC_DRAM_BANK_INFO;
> > + ArmSmcArgs.Arg1 = -1;
>
> Should this be SMC_UNK?
No. SMC_OK / SMC_UNK is returned values.
While x0, x1 are arguments.
I have explained this in the MemoryInitPeiLib.h
// T
Hi Pankaj,
I have a few minor comments on this patch, but I have pushed 1-11/24
as ca1a7187861c..725d1198e262.
On Fri, May 01, 2020 at 11:19:43 +0530, Pankaj Bansal wrote:
> From: Pankaj Bansal
>
> RAM retrieval using SMC commands is common to all Layerscape SOCs.
> Therefore, move it to common
From: Pankaj Bansal
RAM retrieval using SMC commands is common to all Layerscape SOCs.
Therefore, move it to common MemoryInit Pei Lib.
Signed-off-by: Pankaj Bansal
---
Notes:
V4:
- fixed line adds white space error in MemoryInitPeiLib.h
- Added SMC_OK and SMC_UOK Macros to denote
