Hi Bob,
Agree.
Check the size first is more readable than do the type conversion.
That would be align with the address check.
I would send out patch v2 based on this change.
Thanks,
Jason.
-Original Message-
From: Feng, Bob C
Sent: Saturday, June 4, 2022 12:08
To: Lin, Jason1 ;
Hi Jason,
Do you think the code could be more understandable if adding a check for the
size?
if ((gFitTableContext.BiosModule[Index].Address <= Address) &&
(gFitTableContext.BiosModule[Index].Size >= Size) &&
((gFitTableContext.BiosModule[Index].Size - Size) >= (Address -
From: Jason1 Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3922
[Description]
CheckOverlap function would do incorrect split on the BiosModule which not
happen overlap. This would cause incorrect value locate in FIT entry record.
[Condition]
- This BiosModule base address is lower
From: Jason1 Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3922
[Description]
CheckOverlap function would do incorrect split on the BiosModule which not
happen overlap. This would cause incorrect value locate in FIT entry record.
[Condition]
- This BiosModule base address is lower
