Re: [edk2-devel] [PATCH v1] ShellPkg/AcpiView: PrintFormatter for FADT Flags field

2021-11-15 Thread Sami Mujawar
Hi Abdul, Thank you for contributing this patch. Is it possible to introduce a new functionParseAcpiFieldBits () that can trace the bit fields, please? It may also be possible to reuse the ACPI_PARSER structure to specify the Field bits. e.g. Keeping the meaning of the existing ACPI_PARSER

Re: [edk2-devel] [PATCH v1] ShellPkg/AcpiView: PrintFormatter for FADT Flags field

2021-11-14 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Abdul Lateef Attar > Sent: Friday, November 12, 2021 9:27 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; Sami > Mujawar > Subject: [edk2-devel] [PATCH v1] ShellPkg/AcpiView: Prin

[edk2-devel] [PATCH v1] ShellPkg/AcpiView: PrintFormatter for FADT Flags field

2021-11-12 Thread Abdul Lateef Attar via groups.io
Adds PrintFormatter function to the FADT flags field. Prints indivisual flag name along with flag value. Cc: Ray Ni Cc: Zhichao Gao Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar --- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 208 +++- 1