On Thu, Aug 15, 2019 at 10:15:48AM +, Andy Hayes wrote:
> Thanks very much for the very quick feedback from both of you - I
> really appreciate it. I'll fix the issues that you pointed out and
> re-submit the patch.
Thanks!
> I've been testing the build with VisualStudio 2015 and GCC 7.3.
Hi Andy,
A follow-up - a few more things need changing:
UsbDisplayLink.h (well, any .h file) should only contain the headers
it itself requires.
Moreover, the inclusion of wchar.h must disappear completely.
Instead, use CHAR16 * in the two locations in UsbDisplayLink.c.
Removing wchar.h will
Hi Andy,
Many thanks for this submission.
I am finding a few issues when building with gcc/clang (I expect you
use Visual Studio).
The RELEASE target barfs with
.../edk2-platforms/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/Gop.c:363:1:
error: unused function 'CalculateRefreshRate'
since
Hi Andy,
Thanks for the contribution. Is this patch for the edk2-platform repo? The
email subject can help clarify the intended repo.
Also, we prefer the patches to be provided inline instead of an attachment.
You can use the
'git send-email' feature to do this. Here are a couple links to
