Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long

2022-09-22 Thread Kun Qin
ing ; Chen, Christine ; Sean Brogan Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long Reviewed-by: Bob Feng -Original Message- From: Kun Qin Sent: Thursday, September 22, 2022 4:45 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; G

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long

2022-09-22 Thread Bob Feng
] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long Reviewed-by: Bob Feng -Original Message- From: Kun Qin Sent: Thursday, September 22, 2022 4:45 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Sean Brogan Subject: [PATCH

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long

2022-09-22 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Kun Qin Sent: Thursday, September 22, 2022 4:45 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Sean Brogan Subject: [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long

2022-09-21 Thread Sean
Reviewed-by:  Sean Brogan On 9/21/2022 1:44 PM, Kun Qin wrote: From: Sean Brogan Current implementation of looking up toolchain will _insert_ the findings from vsvarsall.bat to existing path and potentially stuff the variable to exceed the length of maximal path length accepted by Windows.

[edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long

2022-09-21 Thread Kun Qin
From: Sean Brogan Current implementation of looking up toolchain will _insert_ the findings from vsvarsall.bat to existing path and potentially stuff the variable to exceed the length of maximal path length accepted by Windows. This change updated the logic to use the discovered shell varialbes