ey, Jaben
>> Sent: Saturday, August 3, 2019 5:24 AM
>> To: devel@edk2.groups.io; jw...@jwatt.org
>> Cc: tim.le...@insyde.com; Gao, Zhichao ; Ni, Ray
>> ; Bi, Dandan ; Rothman, Michael
>> A
>> Subject: RE: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommand
ael
> A
> Subject: RE: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib:
> Fix '-opt' option
>
> I think we can push this in now.
>
> Zhichao,
> Do you agree? If yes, can you prep this for merging?
>
> Thanks
> -Jaben
>
> > -Original Me
@edk2.groups.io
> Cc: tim.le...@insyde.com; Carsey, Jaben ; Gao,
> Zhichao ; Ni, Ray ; Bi, Dandan
>
> Subject: Re: [edk2-devel] [PATCH v1 1/1]
> ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option
>
> It's been three months now since I contributed the patch. Could someone
>
el@edk2.groups.io;
>> tim.le...@insyde.com; Gao, Zhichao ; Ni, Ray
>>
>> Cc: Bi, Dandan
>> Subject: RE: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib:
>> Fix '-opt' option
>>
>> Tim,
>>
>> Does this mean you would support
arsey, Jaben
> Sent: Tuesday, May 7, 2019 5:00 PM
> To: Jonathan Watt ; devel@edk2.groups.io;
> tim.le...@insyde.com; Gao, Zhichao ; Ni, Ray
>
> Cc: Bi, Dandan
> Subject: RE: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib:
> Fix '-opt' option
>
> Tim
2019 2:08 PM
> To: devel@edk2.groups.io; tim.le...@insyde.com; Carsey, Jaben
> ; Gao, Zhichao ; Ni,
> Ray
> Cc: Bi, Dandan
> Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib:
> Fix '-opt' option
> Importance: High
>
> No apologies necessary! Ra
t; To: devel@edk2.groups.io; tim.le...@insyde.com; Carsey, Jaben
> ; Gao, Zhichao ; Ni, Ray
>
> Cc: Bi, Dandan
> Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib:
> Fix '-opt' option
> Importance: High
>
> No apologies necessary! Raising compat
@insyde.com
> Cc: dandan...@intel.com; jw...@jwatt.org; jaben.car...@intel.com;
> zhichao....@intel.com; ray...@intel.com
> Subject: RE: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib:
> Fix '-opt' option
>
> Tim,
>
> Out of curiosity, what does the speci
@intel.com; ray...@intel.com
Subject: RE: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix
'-opt' option
Jim --
Well, speaking of shooting-oneself-in-the-foot, it turns out that our non-EDK2
implementation followed the recommendation in the patch.
I agree that the spec
.groups.io; 'Gao, Zhichao' ; 'Ni, Ray'
Cc: 'Bi, Dandan'
Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix
'-opt' option
Hi Tim,
For context, I'm just some random guy who tripped over this issue on his home
workstation and thought he'd try and remove the footgun to s
> ; devel@edk2.groups.io; 'Gao, Zhichao'
> ; 'Ni, Ray'
> Cc: 'Bi, Dandan'
> Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib:
> Fix '-opt' option
>
> Hi Tim,
>
> For context, I'm just some random guy who tripped over this issue on his home
&
'; 'Carsey, Jaben'; devel@edk2.groups.io; 'Gao, Zhichao';
'Ni, Ray'
Cc: 'Bi, Dandan'
Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix
'-opt' option
Jonathan --
The bcfg command pre-dates the UEFI shell specification. I know of at least two
non-EDK2 implementations
im
>
> -Original Message-
> From: Jonathan Watt
> Sent: Tuesday, May 7, 2019 12:06 PM
> To: Carsey, Jaben ; devel@edk2.groups.io;
> tim.le...@insyde.com; Gao, Zhichao ; Ni, Ray
>
> Cc: Bi, Dandan
> Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShe
3:04 PM
To: 'Jonathan Watt'; 'Carsey, Jaben'; devel@edk2.groups.io; 'Gao, Zhichao';
'Ni, Ray'
Cc: 'Bi, Dandan'
Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix
'-opt' option
Jonathan --
The bcfg command pre-dates the UEFI shell specification. I know of at least two
e.com; Gao, Zhichao ; Ni, Ray
Cc: Bi, Dandan
Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix
'-opt' option
I should add, for me personally, once I noticed the inconsistency I changed my
scripts to use the "0x" prefix to avoid this real footgun. I imagi
devel@edk2.groups.io] On Behalf Of
>> Tim Lewis
>> Sent: Tuesday, May 07, 2019 9:20 AM
>> To: devel@edk2.groups.io; Carsey, Jaben ; Gao,
>> Zhichao ; Ni, Ray ;
>> jw...@jwatt.org
>> Cc: Bi, Dandan
>> Subject: Re: [edk2-devel] [PATCH v1 1/1]
>> ShellPkg/Ue
oups.io; Carsey, Jaben ; Gao,
> Zhichao ; Ni, Ray ;
> jw...@jwatt.org
> Cc: Bi, Dandan
> Subject: Re: [edk2-devel] [PATCH v1 1/1]
> ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option
> Importance: High
>
> The question is whether this will break compatibility with existin
Tim Lewis
> Sent: Tuesday, May 07, 2019 9:20 AM
> To: devel@edk2.groups.io; Carsey, Jaben ; Gao,
> Zhichao ; Ni, Ray ;
> jw...@jwatt.org
> Cc: Bi, Dandan
> Subject: Re: [edk2-devel] [PATCH v1 1/1]
> ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option
> Importance:
Sent: Tuesday, May 7, 2019 7:36 AM
To: Gao, Zhichao ; devel@edk2.groups.io; Ni, Ray
; jw...@jwatt.org
Cc: Bi, Dandan
Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib:
Fix '-opt' option
Zhichao,
I can help submit errata for shell spec if needed.
Per patch,
I agree
From: Carsey, Jaben
> Sent: Tuesday, May 07, 2019 10:36 PM
> To: Gao, Zhichao ; devel@edk2.groups.io; Ni, Ray
> ; jw...@jwatt.org
> Cc: Bi, Dandan
> Subject: RE: [edk2-devel] [PATCH v1 1/1]
> ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option
>
> Zhichao,
> I can help s
sey, Jaben ; Bi, Dandan
>
> Subject: RE: [edk2-devel] [PATCH v1 1/1]
> ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option
> Importance: High
>
> This patch looks good for me.
> Reviewed-by: Zhichao Gao
>
> But when I view the command in UEFI SHELL 2.2 spec:
> ...
by the way.
Thanks,
Zhichao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni,
> Ray
> Sent: Monday, May 6, 2019 10:02 PM
> To: jw...@jwatt.org; devel@edk2.groups.io
> Cc: Carsey, Jaben ; Bi, Dandan
>
> Subject: Re: [e
Dandan,
Can you please help to review?
Thanks,
Ray
> -Original Message-
> From: jw...@jwatt.org [mailto:jw...@jwatt.org]
> Sent: Monday, May 6, 2019 9:03 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray
> Subject: [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt'
23 matches
Mail list logo
