Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Prevent infinite loop if structure length is 0

2020-02-18 Thread Gao, Zhichao
ups.io On Behalf Of Krzysztof > Koch via Groups.Io > Sent: Monday, February 17, 2020 15:23 > To: devel@edk2.groups.io; liming@intel.com > Cc: Ni, Ray ; Gao, Zhichao ; Sami > Mujawar ; Matteo Carlini > ; nd > Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Preve

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Prevent infinite loop if structure length is 0

2020-02-17 Thread Krzysztof Koch
@edk2.groups.io; liming@intel.com Cc: Ni, Ray ; Gao, Zhichao ; Sami Mujawar ; Matteo Carlini ; nd Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Prevent infinite loop if structure length is 0 Hi Liming, I haven't created a BZ yet, shall I create one? It would be great

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Prevent infinite loop if structure length is 0

2020-02-17 Thread Sami Mujawar
Reviewed-by: Sami Mujawar Regards, Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 14 February 2020 13:59 To: devel@edk2.groups.io Cc: ray...@intel.com; zhichao@intel.com; Sami Mujawar ; Matteo Carlini ; nd Subject: [PATCH v1 1/1] ShellPkg: acpiview: Prevent

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Prevent infinite loop if structure length is 0

2020-02-17 Thread Liming Gao
; Mujawar ; Matteo Carlini > ; nd > Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Prevent infinite > loop if structure length is 0 > > Hi Liming, > > I haven't created a BZ yet, shall I create one? It would be great if the > patch makes it to the stable

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Prevent infinite loop if structure length is 0

2020-02-17 Thread Krzysztof Koch
Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Prevent infinite loop if structure length is 0 Krzysztof: Is there one BZ for this issue? Does this patch catch to this edk2 stable tag 202002? Thanks Liming > -Original Message- > From: devel@edk2.groups.io On

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Prevent infinite loop if structure length is 0

2020-02-17 Thread Liming Gao
: Ni, Ray ; Gao, Zhichao ; > sami.muja...@arm.com; matteo.carl...@arm.com; > n...@arm.com > Subject: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Prevent infinite > loop if structure length is 0 > > Extend validation of ACPI structure lengths which are read from the > ACPI ta

[edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Prevent infinite loop if structure length is 0

2020-02-14 Thread Krzysztof Koch
Extend validation of ACPI structure lengths which are read from the ACPI table being parsed. Additionally check if the structure 'Length' field value is positive. If not, stop parsing the faulting table. Some ACPI tables define internal structures of variable size. The 'Length' field inside the