Re: [edk2-devel] [PATCH v1 2/4] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info

2023-01-13 Thread Wu, Jiaxin
Thanks Gerd, I will refine the code logic. > -Original Message- > From: Gerd Hoffmann > Sent: Friday, January 13, 2023 5:51 PM > To: Wu, Jiaxin > Cc: devel@edk2.groups.io; Dong, Eric ; Ni, Ray > ; Zeng, Star ; Laszlo Ersek > ; Kumar, Rahul R > Subject: Re: [PATCH v1 2/4] UefiCpuPkg/PiS

Re: [edk2-devel] [PATCH v1 2/4] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info

2023-01-13 Thread Gerd Hoffmann
Hi, > + } else { > +mSmmInitialized = (BOOLEAN *)AllocateZeroPool (sizeof (BOOLEAN) * > mMaxNumberOfCpus); > +ASSERT (mSmmInitialized != NULL); ASSERT is not sufficient error handling. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

[edk2-devel] [PATCH v1 2/4] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info

2023-01-12 Thread Wu, Jiaxin
SMM CPU driver will retrieve the SMBASE addresses from SMM Base Hob and installs the SMI handler at [SMBASE+8000h] for each processor instead of relocating SMM Base addresses from SMRAM again. With SMM Base Hob, SMM CPU driver does not need the RSM instruction to reload the SMBASE register with th