Re: [edk2-devel] [PATCH v2] BaseTools/PatchCheck.py: Ignore CR and LF characters in subject length

2020-01-20 Thread Philippe Mathieu-Daudé
On 1/20/20 11:27 AM, Laszlo Ersek wrote: On 01/20/20 10:11, Philippe Mathieu-Daudé wrote: Hi Liming, On 1/9/20 6:35 AM, Feng, Bob C wrote: Reviewed-by: Bob Feng Is the Review-by tag from Bob enough to get this patch merged? Yes, see the "M" role: BaseTools F: BaseTools/ W:

Re: [edk2-devel] [PATCH v2] BaseTools/PatchCheck.py: Ignore CR and LF characters in subject length

2020-01-20 Thread Laszlo Ersek
On 01/20/20 10:11, Philippe Mathieu-Daudé wrote: > Hi Liming, > > On 1/9/20 6:35 AM, Feng, Bob C wrote: >> Reviewed-by: Bob Feng > > Is the Review-by tag from Bob enough to get this patch merged? Yes, see the "M" role: BaseTools F: BaseTools/ W:

Re: [edk2-devel] [PATCH v2] BaseTools/PatchCheck.py: Ignore CR and LF characters in subject length

2020-01-20 Thread Philippe Mathieu-Daudé
, January 2, 2020 8:17 PM To: devel@edk2.groups.io Cc: Philippe Mathieu-Daude ; Gao, Liming ; Justen, Jordan L ; Zhu, Yonghong ; Gao, Zhichao Subject: [edk2-devel] [PATCH v2] BaseTools/PatchCheck.py: Ignore CR and LF characters in subject length REF: https://bugzilla.tianocore.org/show_bug.cgi?id

Re: [edk2-devel] [PATCH v2] BaseTools/PatchCheck.py: Ignore CR and LF characters in subject length

2020-01-08 Thread Bob Feng
, Zhichao Subject: [edk2-devel] [PATCH v2] BaseTools/PatchCheck.py: Ignore CR and LF characters in subject length REF: https://bugzilla.tianocore.org/show_bug.cgi?id=113 Strip the trailing characters before checking the subject line is less than 72 characters. Fixes: e61406708c83f Cc: Liming Gao

[edk2-devel] [PATCH v2] BaseTools/PatchCheck.py: Ignore CR and LF characters in subject length

2020-01-02 Thread Philippe Mathieu-Daudé
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=113 Strip the trailing characters before checking the subject line is less than 72 characters. Fixes: e61406708c83f Cc: Liming Gao Cc: Jordan Justen Reviewed-by: Jordan Justen Signed-off-by: Philippe Mathieu-Daude --- Cc: Yonghong Zhu Cc: