Re: [edk2-devel] [PATCH v2] MdeModulePkg/DxeCore: Please static checker for false report

2019-04-27 Thread Wu, Hao A
Thanks all. Patch pushed via commit dfaa565559. Best Regards, Hao Wu > -Original Message- > From: Kinney, Michael D > Sent: Friday, April 26, 2019 10:51 PM > To: Wu, Hao A; Ard Biesheuvel; Gao, Liming; Wang, Jian J; Kinney, Michael D > Cc: edk2-devel-groups-io > Subject: RE: [PATCH v2]

Re: [edk2-devel] [PATCH v2] MdeModulePkg/DxeCore: Please static checker for false report

2019-04-26 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Wu, Hao A > Sent: Thursday, April 25, 2019 10:39 PM > To: Ard Biesheuvel ; Kinney, > Michael D ; Gao, Liming > ; Wang, Jian J > > Cc: edk2-devel-groups-io > Subject: RE: [PATCH v2] MdeModulePkg/DxeCore: Please > static checker

Re: [edk2-devel] [PATCH v2] MdeModulePkg/DxeCore: Please static checker for false report

2019-04-26 Thread Liming Gao
Hao: The change is good to me. Reviewed-by: Liming Gao >-Original Message- >From: Wu, Hao A >Sent: Friday, April 26, 2019 1:39 PM >To: Ard Biesheuvel ; Kinney, Michael D >; Gao, Liming ; Wang, >Jian J >Cc: edk2-devel-groups-io >Subject: RE: [PATCH v2] MdeModulePkg/DxeCore: Please

Re: [edk2-devel] [PATCH v2] MdeModulePkg/DxeCore: Please static checker for false report

2019-04-25 Thread Wu, Hao A
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, April 24, 2019 3:07 PM > To: Wu, Hao A > Cc: edk2-devel-groups-io; Kinney, Michael D; Gao, Liming; Wang, Jian J > Subject: Re: [PATCH v2] MdeModulePkg/DxeCore: Please static checker for >

[edk2-devel] [PATCH v2] MdeModulePkg/DxeCore: Please static checker for false report

2019-04-23 Thread Wu, Hao A
After commit 57df17fe26, some static check reports suspicous NULL pointer deference at line: Entry->MachineType = Entry->Emulator->MachineType; ^^^ within function PeCoffEmuProtocolNotify(). However, 'Entry->Emulator' is guaranteed to have a non-NULL value