Re: [edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowser: Load storage via GetVariable for EfiVarStore

2023-08-04 Thread Dandan Bi
2.groups.io; Bi, Dandan ; Gao, Liming ; Dong, Eric ; Rothman, Michael A Subject: RE: [edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowser: Load storage via GetVariable for EfiVarStore The specific ask is: does the change cause any flexibility lost in HiiConfigAccess implementation? E.g.: somethi

Re: [edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowser: Load storage via GetVariable for EfiVarStore

2023-08-04 Thread Ni, Ray
t: Friday, August 4, 2023 2:01 PM > To: devel@edk2.groups.io; Bi, Dandan ; Gao, Liming > ; Dong, Eric ; Rothman, > Michael A > Subject: RE: [edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowser: Load > storage via GetVariable for EfiVarStore > > + @Rothman, Michael A who designed

Re: [edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowser: Load storage via GetVariable for EfiVarStore

2023-08-04 Thread Ni, Ray
Bi > Sent: Thursday, August 3, 2023 12:53 PM > To: Gao, Liming ; Dong, Eric > ; devel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowser: Load > storage via GetVariable for EfiVarStore > > Hi Liming, > > Yes, with this change, the performance

Re: [edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowser: Load storage via GetVariable for EfiVarStore

2023-08-02 Thread Dandan Bi
Hi Liming, Yes, with this change, the performance is better than before. Especially for the big formset with lots of configuration, it has better use experience when loading the formset to display. Could you help review this patch? Thanks. Thanks, Dandan -Original Message- From:

Re: [edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowser: Load storage via GetVariable for EfiVarStore

2023-07-30 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Bi, Dandan Sent: Monday, July 31, 2023 8:46 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Dong, Eric Subject: [PATCH v2] MdeModulePkg/SetupBrowser: Load storage via GetVariable for EfiVarStore For EfiVarStore

[edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowser: Load storage via GetVariable for EfiVarStore

2023-07-30 Thread Dandan Bi
For EfiVarStore (EFI_HII_VARSTORE_EFI_VARIABLE_BUFFER), it will call ExtractConfig-GetVariable-HiiBlockToConfig-ConfigToBlock when load storage value in LoadStorage function. It's not necessary and costs lots of time to do the conversion between config and block. So now enhance it to call