e Wang
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v2] RedfishPkg: RedfishDiscoverDxe:
Fix issue if IPv4 installed after RestEx
**CAUTION: The e-mail below is from an external source. Please exercise caution
before opening attachments, clicking links, or following guidance.**
Hi Mike,
You are abso
Hi Mike,
You are absolutely right.
I moved that NetworkInterfaceGetSubnetInfo function up, not copied it. But
somehow it was copied.
My mistake.
I will fix it and resubmit.
Thank you,
Igor
-Original Message-
From: Mike Maslenkin
Sent: Friday, November 3, 2023 11:54 AM
To: Igor
On Wed, Nov 1, 2023 at 11:17 PM Igor Kulchytskyy wrote:
>
> Supported function of the driver changed to wait for all newtwork
> interface to be installed.
> Filer out the network interfaces which are not supported by
> Redfish Host Interface.
>
> Cc: Abner Chang
> Cc: Nickle Wang
> Cc: Mike
Hi Nickle,
I fixed all your comments, Abner and Mike comments.
I also created PR
https://github.com/tianocore/edk2/pull/4994/
I fixed all Uncrustify errors and CI passed except PatchCheck which shows the
error
* Missing Signed-off-by! (Note: this must be added by the code contributor!)
Which I'm
[AMD Official Use Only - General]
Only one comment in line.
> -Original Message-
> From: Igor Kulchytskyy
> Sent: Thursday, November 2, 2023 4:18 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Nickle Wang
> ; Mike Maslenkin
> Subject: [PATCH v2] RedfishPkg: RedfishDiscoverDxe: Fix
This change looks good to me. Just minor comments:
> DEBUG ((DEBUG_INFO, "%a: all required protocols are found on this controller
> handle: %p.\n", __func__, ControllerHandle));
Could we use DEBUG_MANAGEABILITY to replace DEBUG_INFO in Redfish driver? This
gives us the way to show
Supported function of the driver changed to wait for all newtwork
interface to be installed.
Filer out the network interfaces which are not supported by
Redfish Host Interface.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Mike Maslenkin
Signed-off-by: Igor Kulchytskyy
---
