[Public]
+Laszlo, +Gerd, +Paolo
PR: https://github.com/tianocore/edk2/pull/4982
-Original Message-
From: Lin, Jacque
Sent: Tuesday, October 31, 2023 11:07 AM
To: devel@edk2.groups.io
Cc: Lin, Jacque ; Attar, AbdulLateef (Abdul Lateef)
; Chang, Abner
Subject: [PATCH v2]
On Tue, Oct 31, 2023 at 10:16 AM Attar, AbdulLateef (Abdul Lateef)
wrote:
>
> [Public]
>
> +Laszlo, +Gerd, +Paolo
> PR: https://github.com/tianocore/edk2/pull/4982
I left a comment in the PR.
The patch is only correct if this code is only ever used on 64-bit
processors. Note that KVM uses the
Hi,
On 10/31/23 10:15, Attar, AbdulLateef (Abdul Lateef) wrote:
> [Public]
>
> +Laszlo, +Gerd, +Paolo
> PR: https://github.com/tianocore/edk2/pull/4982
... My opinion, stated elsewhere in this thread in detail, is that this
patch is wrong, and should not be merged.
Laszlo
>
> -Original
Remove checking SMM Rev ID in AMD Save State lib when reading Save
State Register EFI_MM_SAVE_STATE_REGISTER_IO.
For AMD, it is not necessary to check SmmRevId when reading Save State
Register EFI_MM_SAVE_STATE_REGISTER_IO.
Cc: Abdul Lateef Attar
Cc: Abner Chang
Signed-off-by: Jacque Lin
---
