Re: [edk2-devel] [PATCH v2 03/11] ShellPkg: acpiview: FADT: Validate global pointer before use

2019-08-20 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Krzysztof Koch [mailto:krzysztof.k...@arm.com] > Sent: Monday, August 19, 2019 4:25 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; sami.muja...@arm.com; > matteo.carl...@arm.com;

Re: [edk2-devel] [PATCH v2 03/11] ShellPkg: acpiview: FADT: Validate global pointer before use

2019-08-20 Thread Sami Mujawar
Reviewed-by: Sami Mujawar Regards, Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 19 August 2019 09:25 AM To: devel@edk2.groups.io Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami Mujawar ; Matteo Carlini ; nd Subject: [PATCH v2 03/11]

Re: [edk2-devel] [PATCH v2 03/11] ShellPkg: acpiview: FADT: Validate global pointer before use

2019-08-19 Thread Alexei Fedorov
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#46028): https://edk2.groups.io/g/devel/message/46028 Mute This Topic: https://groups.io/mt/32941781/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

[edk2-devel] [PATCH v2 03/11] ShellPkg: acpiview: FADT: Validate global pointer before use

2019-08-19 Thread Krzysztof Koch
Check if global pointers have been successfully updated before they are used for further table parsing. Signed-off-by: Krzysztof Koch --- Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/tree/612_add_pointer_validation_v2 Notes: v1: - Test against NULL pointers