Re: [edk2-devel] [PATCH v2 08/10] OvmfPkg/ResetVector: wire up 5-level paging for TDX

2024-03-01 Thread Gerd Hoffmann
Hi, > Did you place the "CheckForSev:" label intentionally outside of the %if > scope? If it was intentional, then I'm OK with it. > > If it was unintended / an oversight, then next question: do you want me > to move the label into the %if's scope for you, upon merge? Or do you > like it

Re: [edk2-devel] [PATCH v2 08/10] OvmfPkg/ResetVector: wire up 5-level paging for TDX

2024-03-01 Thread Laszlo Ersek
On 3/1/24 08:44, Gerd Hoffmann wrote: > BSP workflow is quite simliar to the non-coco case. > > TDX_WORK_AREA_PGTBL_READY is used to record the paging mode: > 1 == 4-level paging > 2 == 5-level paging > > APs will look at TDX_WORK_AREA_PGTBL_READY to figure whenever > they should enable

[edk2-devel] [PATCH v2 08/10] OvmfPkg/ResetVector: wire up 5-level paging for TDX

2024-02-29 Thread Gerd Hoffmann
BSP workflow is quite simliar to the non-coco case. TDX_WORK_AREA_PGTBL_READY is used to record the paging mode: 1 == 4-level paging 2 == 5-level paging APs will look at TDX_WORK_AREA_PGTBL_READY to figure whenever they should enable 5-level paging or not. Signed-off-by: Gerd Hoffmann ---