回复: [edk2-devel] [PATCH v2 1/1] BaseTools: Align include guards policy

2021-02-25 Thread gaoliming
inc.com; sami.muja...@arm.com > 抄送: l...@nuviainc.com > 主题: 回复: [edk2-devel] [PATCH v2 1/1] BaseTools: Align include guards > policy > > I am OK to add this checker in ECC. > > Reviewed-by: Liming Gao > > > -邮件原件- > > 发件人: bounce+27952+71693+4905953+8761

回复: [edk2-devel] [PATCH v2 1/1] BaseTools: Align include guards policy

2021-02-17 Thread gaoliming
c.com; > sami.muja...@arm.com > 抄送: l...@nuviainc.com > 主题: [edk2-devel] [PATCH v2 1/1] BaseTools: Align include guards policy > > From: Pierre Gondois > > The EDK II C Coding Standards Specification states that: > "Names starting with one or two underscores, such a

回复: [edk2-devel] [PATCH v2 1/1] BaseTools: Align include guards policy

2021-02-17 Thread gaoliming
ob C > ; gaolim...@byosoft.com.cn; rebe...@nuviainc.com; > sami.muja...@arm.com > 抄送: l...@nuviainc.com > 主题: Re: [edk2-devel] [PATCH v2 1/1] BaseTools: Align include guards policy > > Hi Pierre, > > There seems already have a Bugzilla link for this issue: > https://b

Re: [edk2-devel] [PATCH v2 1/1] BaseTools: Align include guards policy

2021-02-17 Thread Yuwei Chen
: devel@edk2.groups.io; Feng, Bob C ; > gaolim...@byosoft.com.cn; rebe...@nuviainc.com; > sami.muja...@arm.com > Cc: l...@nuviainc.com > Subject: [edk2-devel] [PATCH v2 1/1] BaseTools: Align include guards policy > > From: Pierre Gondois > > The EDK II C Coding Standards S

Re: [edk2-devel] [PATCH v2 1/1] BaseTools: Align include guards policy

2021-02-16 Thread PierreGondois
I forgot to mention: a bugzilla was created for this topic at https://bugzilla.tianocore.org/show_bug.cgi?id=3212 Regards, Pierre -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71694): https://edk2.groups.io/g/devel/message/71694 Mute

[edk2-devel] [PATCH v2 1/1] BaseTools: Align include guards policy

2021-02-16 Thread PierreGondois
From: Pierre Gondois The EDK II C Coding Standards Specification states that: "Names starting with one or two underscores, such as _MACRO_GUARD_FILE_NAME_H_, must not be used. They are reserved for compiler implementation." [1] The Ecc tool currently checks that the include guard end with a