Hi Rebecca,
Thank you for this patch series.
The patch series does not apply on top of latest master, which I believe
is due to the Uncrustify changes.
I have some minor suggestions marked inline as [SAMI].
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami
Hi Ard,
On 13/12/2021 11:49 AM, Ard Biesheuvel wrote:
On Thu, 9 Dec 2021 at 23:54, Rebecca Cran wrote:
Now that the edk2 tree is unfrozen, I'd like to get this committed.
Could anyone else review it please, or if it's ready commit it?
I think this is fine to go in, but you'll need to
On Thu, 9 Dec 2021 at 23:54, Rebecca Cran wrote:
>
> Now that the edk2 tree is unfrozen, I'd like to get this committed.
>
> Could anyone else review it please, or if it's ready commit it?
>
>
I think this is fine to go in, but you'll need to rebase on top of the
uncrustify changes in any case.
Now that the edk2 tree is unfrozen, I'd like to get this committed.
Could anyone else review it please, or if it's ready commit it?
Thanks.
Rebecca Cran
On 11/9/21 5:15 AM, Ard Biesheuvel wrote:
On Tue, 9 Nov 2021 at 12:57, Leif Lindholm wrote:
On Mon, Nov 08, 2021 at 18:56:09 -0700,
On Tue, 9 Nov 2021 at 12:57, Leif Lindholm wrote:
>
> On Mon, Nov 08, 2021 at 18:56:09 -0700, Rebecca Cran wrote:
> > Could I have some reviews on this please?
>
> I'm all for it. It's clunky, but less clunky than the situation
> without, and it improves readability at call sites.
>
> Ard had
On Mon, Nov 08, 2021 at 18:56:09 -0700, Rebecca Cran wrote:
> Could I have some reviews on this please?
I'm all for it. It's clunky, but less clunky than the situation
without, and it improves readability at call sites.
Ard had some reservations for v1 not actually adding any users.
Ard - do you
Could I have some reviews on this please?
--
Rebecca Cran
On 11/1/21 4:11 PM, Rebecca Cran wrote:
Add functions ArmCallSmc0/1/2/3 to do SMC calls with 0, 1, 2 or 3
arguments.
The functions return up to 3 values.
Signed-off-by: Rebecca Cran
---
ArmPkg/Include/Library/ArmSmcLib.h
Add functions ArmCallSmc0/1/2/3 to do SMC calls with 0, 1, 2 or 3
arguments.
The functions return up to 3 values.
Signed-off-by: Rebecca Cran
---
ArmPkg/Include/Library/ArmSmcLib.h | 73
ArmPkg/Library/ArmSmcLib/ArmSmc.c| 122
