Re: [edk2-devel] [PATCH v2 1/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrGetVariableMtrr()

2020-07-13 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Monday, July 13, 2020 4:13 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek ; > Kumar, Rahul1 > Subject: [edk2-devel] [PATCH v2 1/3] UefiC

Re: [edk2-devel] [PATCH v2 1/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrGetVariableMtrr()

2020-07-13 Thread Laszlo Ersek
On 07/13/20 10:12, Ni, Ray wrote: > MtrrGetVariableMtrr() returns all the variable MTRR settings. > But in fact MtrrGetAllMtrrs() and > MtrrGetMemoryAttributeInVariableMtrr() are used by callers to get the > MTRR settings. The former one returns both the fixed and variable > MTRR settings. > > The

[edk2-devel] [PATCH v2 1/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrGetVariableMtrr()

2020-07-13 Thread Ni, Ray
MtrrGetVariableMtrr() returns all the variable MTRR settings. But in fact MtrrGetAllMtrrs() and MtrrGetMemoryAttributeInVariableMtrr() are used by callers to get the MTRR settings. The former one returns both the fixed and variable MTRR settings. The patch removes the necessary API MtrrGetVariable