Re: [edk2-devel] [PATCH v2 1/4] IntelFsp2Pkg: Add FSP 2.4 MultiPhase interface.

2022-08-30 Thread Nate DeSimone
Hi Chasel, Please see feedback inline. Specifically, some improvements are needed in the comments. The code itself looks good! For that reason, there is no need to send a V3 patch series. Please fix the comments then you are free to push the change. With those changes... Reviewed-by: Nate

[edk2-devel] [PATCH v2 1/4] IntelFsp2Pkg: Add FSP 2.4 MultiPhase interface.

2022-08-09 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3916 Provide FSP 2.4 MultiPhase interface and scripts support. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/Library/BaseFspMultiPhaseLib/FspMultiPhaseLib.c | 184