Re: [edk2-devel] [PATCH v2 2/2] ShellPkg/Acpiview: Adds ACPI WSMT Table parse

2024-03-08 Thread PierreGondois
Hell Abdul, On 3/8/24 13:45, Attar, AbdulLateef (Abdul Lateef) wrote: Hi Pierre,     I think the provided patch also serve the same purpose of validating the COMM_BUFFER_NESTED_PTR_PROTECTION against FIXED_COMM_BUFFERS. Ok right, I didn't see it was checked in ValidateWsmtProtectionFlag().

Re: [edk2-devel] [PATCH v2 2/2] ShellPkg/Acpiview: Adds ACPI WSMT Table parse

2024-03-08 Thread Abdul Lateef Attar via groups.io
Hi Pierre,     I think the provided patch also serve the same purpose of validating the COMM_BUFFER_NESTED_PTR_PROTECTION against FIXED_COMM_BUFFERS. Do you want me to remove the "ValidateReserved" implementation? Here is the sample test results. 1)   Protection Flag    :

Re: [edk2-devel] [PATCH v2 2/2] ShellPkg/Acpiview: Adds ACPI WSMT Table parse

2024-03-08 Thread PierreGondois
Hello Abdul, On 3/8/24 08:22, Abdul Lateef Attar wrote: From: Abdul Lateef Attar Adds WSMT parse to the UefiShellAcpiViewCommandLib library. Cc: Zhichao Gao Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois ---

[edk2-devel] [PATCH v2 2/2] ShellPkg/Acpiview: Adds ACPI WSMT Table parse

2024-03-07 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar Adds WSMT parse to the UefiShellAcpiViewCommandLib library. Cc: Zhichao Gao Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar Reviewed-by: Pierre Gondois --- .../UefiShellAcpiViewCommandLib/AcpiParser.h | 17 ++ .../Parsers/Wsmt/WsmtParser.c