Re: [edk2-devel] [PATCH v2 2/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrSetVariableMtrr()

2020-07-13 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Monday, July 13, 2020 4:13 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek ; > Kumar, Rahul1 > Subject: [edk2-devel] [PATCH v2 2/3] UefiC

Re: [edk2-devel] [PATCH v2 2/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrSetVariableMtrr()

2020-07-13 Thread Laszlo Ersek
On 07/13/20 10:12, Ni, Ray wrote: > MtrrSetVariableMtrr() sets all the variable MTRR settings. > But in fact MtrrSetAllMtrrs() is always used by callers to set all > MTRR settings including the fixed and variable ones. > > The patch removes the necessary API MtrrSetVariableMtrr() to simplify (1)

[edk2-devel] [PATCH v2 2/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrSetVariableMtrr()

2020-07-13 Thread Ni, Ray
MtrrSetVariableMtrr() sets all the variable MTRR settings. But in fact MtrrSetAllMtrrs() is always used by callers to set all MTRR settings including the fixed and variable ones. The patch removes the necessary API MtrrSetVariableMtrr() to simplify the MtrrLib API. There is no code in edk2 and ed