Re: [edk2-devel] [PATCH v3 2/7] ArmPkg/ArmSoftFloatLib: switch to new version of softfloat library

2019-05-31 Thread Ard Biesheuvel
On Fri, 31 May 2019 at 15:49, Leif Lindholm wrote: > > On Fri, May 31, 2019 at 03:39:33PM +0200, Ard Biesheuvel wrote: > > On Fri, 31 May 2019 at 15:26, Leif Lindholm > > wrote: > > > > > > On Fri, May 31, 2019 at 03:22:25PM +0200, Ard Biesheuvel wrote: > > > > > > + GCC:*_*_*_CC_FLAGS = -fno-l

Re: [edk2-devel] [PATCH v3 2/7] ArmPkg/ArmSoftFloatLib: switch to new version of softfloat library

2019-05-31 Thread Leif Lindholm
On Fri, May 31, 2019 at 03:39:33PM +0200, Ard Biesheuvel wrote: > On Fri, 31 May 2019 at 15:26, Leif Lindholm wrote: > > > > On Fri, May 31, 2019 at 03:22:25PM +0200, Ard Biesheuvel wrote: > > > > > + GCC:*_*_*_CC_FLAGS = -fno-lto -ffreestanding -Wno-unused-label > > > > > > > > Hmm. You add -ffr

Re: [edk2-devel] [PATCH v3 2/7] ArmPkg/ArmSoftFloatLib: switch to new version of softfloat library

2019-05-31 Thread Ard Biesheuvel
On Fri, 31 May 2019 at 15:26, Leif Lindholm wrote: > > On Fri, May 31, 2019 at 03:22:25PM +0200, Ard Biesheuvel wrote: > > > > + GCC:*_*_*_CC_FLAGS = -fno-lto -ffreestanding -Wno-unused-label > > > > > > Hmm. You add -ffreestanding here, but you also add it to the CLANG > > > profiles in 4/7. Cou

Re: [edk2-devel] [PATCH v3 2/7] ArmPkg/ArmSoftFloatLib: switch to new version of softfloat library

2019-05-31 Thread Leif Lindholm
On Fri, May 31, 2019 at 03:22:25PM +0200, Ard Biesheuvel wrote: > > > + GCC:*_*_*_CC_FLAGS = -fno-lto -ffreestanding -Wno-unused-label > > > > Hmm. You add -ffreestanding here, but you also add it to the CLANG > > profiles in 4/7. Could we do one of: > > - dropping this one, adding -ffreestanding

Re: [edk2-devel] [PATCH v3 2/7] ArmPkg/ArmSoftFloatLib: switch to new version of softfloat library

2019-05-31 Thread Ard Biesheuvel
On Fri, 31 May 2019 at 15:20, Leif Lindholm wrote: > > On Fri, May 31, 2019 at 02:49:53PM +0200, Ard Biesheuvel wrote: > > diff --git a/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf > > b/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf > > index cbb49f49ade6..4d0c94df83db 100644 > > --- a

Re: [edk2-devel] [PATCH v3 2/7] ArmPkg/ArmSoftFloatLib: switch to new version of softfloat library

2019-05-31 Thread Leif Lindholm
On Fri, May 31, 2019 at 02:49:53PM +0200, Ard Biesheuvel wrote: > diff --git a/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf > b/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf > index cbb49f49ade6..4d0c94df83db 100644 > --- a/ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf > +++ b/ArmP

[edk2-devel] [PATCH v3 2/7] ArmPkg/ArmSoftFloatLib: switch to new version of softfloat library

2019-05-31 Thread Ard Biesheuvel
Update the INF description and the top level .c files in order to switch to the new version of the SoftFloat library imported as a Git submodule in the previous patch. Note that we no longer use the code that travelled a long way from the 2002 version of the softfloat library via NetBsd and the St