回复: [edk2-devel] [PATCH v5] MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool size

2023-09-10 Thread gaoliming via groups.io
2-devel] [PATCH v5] MdeModulePkg/HiiDatabase: Fix incorrect > AllocateCopyPool size > > Reviewed-by: Dandan Bi > > > Thanks, > Dandan > > -Original Message- > From: Mike Beaton > Sent: Thursday, September 7, 2023 11:35 AM > To: devel@edk2.groups.io > Cc:

Re: [edk2-devel] [PATCH v5] MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool size

2023-09-07 Thread Dandan Bi
Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Mike Beaton Sent: Thursday, September 7, 2023 11:35 AM To: devel@edk2.groups.io Cc: Dong, Eric ; Bi, Dandan ; Ard Biesheuvel ; Mike Beaton Subject: [PATCH v5] MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool

回复: [edk2-devel] [PATCH v5] MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool size

2023-09-07 Thread gaoliming via groups.io
gt; Ard Biesheuvel ; Mike Beaton > 主题: [edk2-devel] [PATCH v5] MdeModulePkg/HiiDatabase: Fix incorrect > AllocateCopyPool size > > The immediately preceding call, GetBestLanguage, plus the implementation of > HiiGetString, which is called immediately afterwards, make it clear that &g

Re: [edk2-devel] [PATCH v5] MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool size

2023-09-07 Thread Ard Biesheuvel
On Thu, 7 Sept 2023 at 05:35, Mike Beaton wrote: > > The immediately preceding call, GetBestLanguage, plus the implementation of > HiiGetString, which is called immediately afterwards, make it clear that > BestLanguage is a null-terminated ASCII string, and not just a five byte, > non-null

Re: [edk2-devel] [PATCH v5] MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool size

2023-09-06 Thread Mike Beaton
On Thu, 7 Sept 2023 at 04:35, Mike Beaton wrote: > > The immediately preceding call, GetBestLanguage, plus the implementation of > HiiGetString, which is called immediately afterwards, make it clear that > BestLanguage is a null-terminated ASCII string, and not just a five byte, > non-null

[edk2-devel] [PATCH v5] MdeModulePkg/HiiDatabase: Fix incorrect AllocateCopyPool size

2023-09-06 Thread Mike Beaton
The immediately preceding call, GetBestLanguage, plus the implementation of HiiGetString, which is called immediately afterwards, make it clear that BestLanguage is a null-terminated ASCII string, and not just a five byte, non-null terminated buffer. Therefore AsciiStrLen is one byte too short,