Re: [edk2-devel] [PATCH v6 00/16] Add a plugin to check Ecc issues for edk2 on open ci

2020-07-05 Thread Zhang, Shenglei
Hi Lazslo, Looks like I missed your ACK. I will add it in latter versions. Thanks, Shenglei > -Original Message- > From: Laszlo Ersek > Sent: Saturday, July 4, 2020 12:02 AM > To: Gao, Liming ; devel@edk2.groups.io; Zhang, > Shenglei ; Leif Lindholm ; > af...@apple.com > Cc: Feng, Bob

Re: [edk2-devel] [PATCH v6 00/16] Add a plugin to check Ecc issues for edk2 on open ci

2020-07-03 Thread Laszlo Ersek
Hi Liming, On 07/03/20 17:13, Gao, Liming wrote: > Include more people and collect the comments. > > ECC is the source file coding style checker. Here is its wiki page > https://github.com/tianocore/tianocore.github.io/wiki/ECC-tool. > If the changed code doesn't follow edk2 coding style, ECC

Re: [edk2-devel] [PATCH v6 00/16] Add a plugin to check Ecc issues for edk2 on open ci

2020-07-03 Thread Liming Gao
Include more people and collect the comments. ECC is the source file coding style checker. Here is its wiki page https://github.com/tianocore/tianocore.github.io/wiki/ECC-tool. If the changed code doesn't follow edk2 coding style, ECC will report the error. This patch set enables ECC checker

Re: [edk2-devel] [PATCH v6 00/16] Add a plugin to check Ecc issues for edk2 on open ci

2020-07-02 Thread Zhang, Shenglei
Liming, Yes we have instructions to run plugins locally. Since they are not good enough and not easy to find. I provide the following steps. Pre-Requisites * Windows OS * Make sure you have python 3.7.x or newer available on path * Make sure you have git installed and available on path 1.

Re: [edk2-devel] [PATCH v6 00/16] Add a plugin to check Ecc issues for edk2 on open ci

2020-07-01 Thread Liming Gao
Shenglei: Thanks for your work to enable ECC checker in open CI. Have you the step to run this checker in local environment? The developer may want to reproduce the issue and fix it. Thanks Liming -Original Message- From: devel@edk2.groups.io On Behalf Of Zhang, Shenglei Sent:

[edk2-devel] [PATCH v6 00/16] Add a plugin to check Ecc issues for edk2 on open ci

2020-06-30 Thread Zhang, Shenglei
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606 As planed we will enable Ecc check for edk2 on open ci. And they are ready now. I appreciate receiving feedback and comments if someone find errors or false positive issues. I created a pipline of EccCheck for my forked edk2. Welcome