Hi Leif,
I'll update it and send another patch on top of the previously reviewed patch.
Thanks!
> -Original Message-
> From: Leif Lindholm
> Sent: Friday, August 9, 2019 6:16 PM
> To: Loh, Tien Hock
> Cc: Kinney, Michael D ; devel@edk2.groups.io;
> thlo...@gmail.com; Ard Biesheuvel
Hi Tien Hock,
Given Mike's review, could you roll a v7 with all of the incorporated
feedback from Mike based on this (instead of submitting the v6 updates
as a separate patch, which I previously requested)?
Could you also roll in the following in that patch?:
diff --git a/Maintainers.txt
> -Original Message-
> From: Kinney, Michael D
> Sent: Friday, August 9, 2019 3:50 AM
> To: Leif Lindholm ; Loh, Tien Hock
> ; Kinney, Michael D
>
> Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard Biesheuvel
>
> Subject: RE: [PATCH v6 1/1] Platform: Intel: Add Stratix 10 platform
Tien Hock,
I have a few comments:
1) Recommend change name of directory
Platform/Intel/Startix10 -> Platform/Intel/Startix10SocPkg.
2) S10ClockManager.c is missing file header with license and copyright
3) S10ClockManager.h is missing file header with license and copyright
4)
Hi Leif,
OK noted, I'll submit a new patch on top of the commit.
I'll also try to ping Micheal.
Thanks
Tien Hock
> -Original Message-
> From: Leif Lindholm
> Sent: Monday, August 5, 2019 5:26 PM
> To: Loh, Tien Hock ; Kinney, Michael D
>
> Cc: devel@edk2.groups.io; thlo...@gmail.com;
Hi Tien Hock,
I have already given my reviewed-by to v5 of this patch.
So can you please resubmit the changes since then as a separate patch?
But I am still waiting for a response from Mike to
https://edk2.groups.io/g/devel/message/44042
before I am able to push the platform support.
Best
Hi Leif, Ard, Micheal,
Any comments on this patch?
Thanks
Tien Hock
> -Original Message-
> From: Loh, Tien Hock
> Sent: Thursday, August 1, 2019 6:32 PM
> To: devel@edk2.groups.io; thlo...@gmail.com
> Cc: Loh, Tien Hock ; Ard Biesheuvel
> ; Leif Lindholm ;
> Kinney, Michael D
>
Hi Leif, Ard, Micheal,
Any comments on this?
Thanks!
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#44890): https://edk2.groups.io/g/devel/message/44890
Mute This Topic: https://groups.io/mt/32677389/21656
Group Owner:
From: "Tien Hock, Loh"
Adds support for Intel Stratix 10 Platform.
Signed-off-by: "Tien Hock, Loh"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael D Kinney
---
v5:
Remove hardcoded UART clock
---
