Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

2020-05-08 Thread Lendacky, Thomas
On 5/6/20 9:38 PM, Dong, Eric wrote: Hi Tom, Hi Eric, -Original Message- From: Tom Lendacky Sent: Thursday, May 7, 2020 2:33 AM To: Dong, Eric ; devel@edk2.groups.io; ler...@redhat.com Cc: Justen, Jordan L ; Ard Biesheuvel ; Kinney, Michael D ; Gao, Liming ; Ni, Ray ; Brijesh

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

2020-05-06 Thread Dong, Eric
Hi Tom, > -Original Message- > From: Tom Lendacky > Sent: Thursday, May 7, 2020 2:33 AM > To: Dong, Eric ; devel@edk2.groups.io; > ler...@redhat.com > Cc: Justen, Jordan L ; Ard Biesheuvel > ; Kinney, Michael D > ; Gao, Liming ; Ni, Ray > ; Brijesh Singh ; Wang, Jian J > ; Wu, Hao A >

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

2020-05-06 Thread Dong, Eric
Hi Tom, > -Original Message- > From: Tom Lendacky > Sent: Thursday, May 7, 2020 2:33 AM > To: Dong, Eric ; devel@edk2.groups.io; > ler...@redhat.com > Cc: Justen, Jordan L ; Ard Biesheuvel > ; Kinney, Michael D > ; Gao, Liming ; Ni, Ray > ; Brijesh Singh ; Wang, Jian J > ; Wu, Hao A >

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

2020-05-06 Thread Lendacky, Thomas
Hi Eric, On 5/6/20 10:06 AM, Dong, Eric wrote: > Hi Tom, > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of >> Lendacky, Thomas >> Sent: Wednesday, May 6, 2020 9:20 PM >> To: Dong, Eric ; devel@edk2.groups.io; >> ler...@redhat.com >> Cc: Justen, Jordan L ; Ard Biesheuvel

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

2020-05-06 Thread Laszlo Ersek
On 05/06/20 15:19, Tom Lendacky wrote: > On 5/5/20 8:53 PM, Dong, Eric wrote: >> >> >>> -Original Message- >>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >>> Laszlo Ersek >>> Sent: Tuesday, May 5, 2020 11:30 PM >>> To: Tom Lendacky ; Dong, Eric >>> ;

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

2020-05-06 Thread Dong, Eric
Hi Tom, > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Lendacky, Thomas > Sent: Wednesday, May 6, 2020 9:20 PM > To: Dong, Eric ; devel@edk2.groups.io; > ler...@redhat.com > Cc: Justen, Jordan L ; Ard Biesheuvel > ; Kinney, Michael D > ; Gao, Liming ; Ni, Ray > ;

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

2020-05-06 Thread Lendacky, Thomas
On 5/5/20 8:53 PM, Dong, Eric wrote: -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo Ersek Sent: Tuesday, May 5, 2020 11:30 PM To: Tom Lendacky ; Dong, Eric ; devel@edk2.groups.io Cc: Justen, Jordan L ; Ard Biesheuvel ; Kinney, Michael D

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

2020-05-05 Thread Dong, Eric
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Tuesday, May 5, 2020 11:30 PM > To: Tom Lendacky ; Dong, Eric > ; devel@edk2.groups.io > Cc: Justen, Jordan L ; Ard Biesheuvel > ; Kinney, Michael D > ; Gao, Liming ; Ni,

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

2020-05-05 Thread Laszlo Ersek
On 05/04/20 18:41, Tom Lendacky wrote: > Is there an easy way to run everything that this link points, too? Is it > just creating a pull request that does this? I don't want to take up a > lot of your time, so if there's some documentation on how to run an > integration test to find and fix

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

2020-05-04 Thread Lendacky, Thomas
On 5/4/20 8:47 AM, Dong, Eric wrote: Hi Tom, Hi Eric, Those errors are not the only errors I met. I also created a pull request to test your patch serial and it reported some errors. Please check the result,

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

2020-05-04 Thread Dong, Eric
Hi Tom, Those errors are not the only errors I met. I also created a pull request to test your patch serial and it reported some errors. Please check the result, https://github.com/tianocore/edk2/pull/575. Thanks, Eric -Original Message- From: Tom Lendacky Sent: Monday, May 4, 2020

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

2020-05-04 Thread Lendacky, Thomas
On 5/2/20 3:19 AM, Dong, Eric wrote: Hi Tom, Hi Eric, Can you describe what tests have you done for this patch serial? I've built the OVMF package in 32, 32/64 and 64-bit configurations on Linux using GCC as the compiler. These warnings were not emitted in those configurations. I'll

Re: [edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

2020-05-02 Thread Dong, Eric
Hi Tom, Can you describe what tests have you done for this patch serial? I just build the UefiCpupkg. Dsc with VS2015x86 and met below errors: g:\edk2-open-source\edk2\UefiCpuPkg\Library\CpuExceptionHandlerLib\X64\ArchAMDSevVcHandler.c(730): warning C4245: 'function': conversion from 'int' to

[edk2-devel] [PATCH v7 01/43] MdeModulePkg: Create PCDs to be used in support of SEV-ES

2020-04-22 Thread Lendacky, Thomas
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Two new dynamic MdeModulePkg PCDs are needed to support SEV-ES under OVMF: - PcdGhcbBase: UINT64 value that is the base address of the GHCB allocation. - PcdGhcbSize: UINT64 value that is the size, in