Thanks Ray! I have sent a code review for removing EFIAPI, please help to
review.
Thanks,
Chasel
> -Original Message-
> From: Ni, Ray
> Sent: Monday, December 20, 2021 1:15 PM
> To: S, Ashraf Ali ; devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; Kuo,
+UINTN
+EFIAPI
+GetFspmUpdDataAddress (
+ VOID
+ )
This is internal function. Please remove "EFIAPI".
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#85101): https://edk2.groups.io/g/devel/message/85101
Mute This Topic:
Patch pushed:
https://github.com/tianocore/edk2/commit/de9e5b7dc721d4ca319c0455cf83577347e0abef
Thanks,
Chasel
> -Original Message-
> From: S, Ashraf Ali
> Sent: Thursday, December 16, 2021 4:10 PM
> To: devel@edk2.groups.io
> Cc: S, Ashraf Ali ; Chiu, Chasel
> ;
> Desimone,
How about adding the minor comments like below?
#
# Non-0 means PcdFspmUpdDataAddress will be ignored, otherwise
PcdFspmUpdDataAddress will be used.
#
gIntelFsp2WrapperTokenSpaceGuid.PcdFspmUpdDataAddress64|0x|UINT64|0x5002
#
# Non-0 means PcdFspsUpdDataAddress will be ignored,
Thanks Ashraf!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: S, Ashraf Ali
> Sent: Thursday, December 16, 2021 4:10 PM
> To: devel@edk2.groups.io
> Cc: S, Ashraf Ali ; Chiu, Chasel
> ;
> Desimone, Nathaniel L ; Zeng, Star
> ; Kuo, Ted ; Duggapu, Chinni B
> ; Chaganty,
Hi Ted,
Some bootloaders may choose to always use PcdFspmUpdDataAddress64 regardless
32bit or 64bit builds, we do not need to block such usage cases by checking
UINTN size.
Thanks,
Chasel
> -Original Message-
> From: Kuo, Ted
> Sent: Thursday, December 16, 2021 6:47 PM
> To: S,
Can we use the size of UINTN instead of the value of PcdFspmUpdDataAddress64 to
decide which PCD should be returned in GetFspmUpdDataAddress and
GetFspsUpdDataAddress?
Thanks,
Ted
-Original Message-
From: S, Ashraf Ali
Sent: Thursday, December 16, 2021 4:10 PM
To:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3642
when the module is not building in IA32 mode which will lead to building
error. when a module built-in X64 function pointer will be the size of
64bit width which cannot be fit in 32bit address which will lead to
error. to overcome this issue
