4 minor comments.
> +if (FadtPtr->XFirmwareCtrl) {
1. you should use "if (FadtPtr->XFirmwareCtrl != 0)" to align with edk2 coding
style.
>
> + CallbackFunction ((EFI_ACPI_COMMON_HEADER
> *)(UINTN)FadtPtr->XFirmwareCtrl, TableIndex++, Context);
>
> +} else {
>
> +
Thanks for the reviewing Ankit!
It looks to me current version is good enough for merging, if no other
feedbacks I will help to merge it tomorrow.
Thanks,
Chasel
> -Original Message-
> From: Sinha, Ankit
> Sent: Tuesday, May 30, 2023 8:53 AM
> To: Ke, VincentX ; devel@edk2.groups.io
Reviewed-by: Ankit Sinha
Thank you,
Ankit
> -Original Message-
> From: Ke, VincentX
> Sent: Wednesday, May 24, 2023 1:39 AM
> To: devel@edk2.groups.io
> Cc: Ke, VincentX ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W
> ; Gao, Liming ;
> Dong, Eric ; Sinha, Ankit
> Subject:
From: VincentX Ke
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4428
Calculating CRC based on each ACPI table.
Update HWSignature field in FACS based on CRC while ACPI table changed.
Change-Id: Ic0ca66ff10cda0fbcd0683020fab1bc9aea9b78c
Signed-off-by: VincentX Ke
Cc: Chasel Chiu
Cc: Nate
