Thanks.
Pushed. SHA-1: bb824f685d760f560bb3c3fb14af394ab3b3544f
Thanks,
Bob
-Original Message-
From: Gao, Liming
Sent: Monday, July 22, 2019 11:43 AM
To: Feng, Bob C ; devel@edk2.groups.io
Subject: RE: [edk2-devel] [Patch] BaseTools: Fixed the mis-using strip()
function issue.
Ok
Ok. Make sense.
Reviewed-by: Liming Gao
> -Original Message-
> From: Feng, Bob C
> Sent: Monday, July 22, 2019 8:48 AM
> To: Gao, Liming ; devel@edk2.groups.io
> Subject: RE: [edk2-devel] [Patch] BaseTools: Fixed the mis-using strip()
> function issue.
>
>
gn.lstrip("/Fo") removes "/FoF".
Thanks,
Bob
-Original Message-
From: Gao, Liming
Sent: Sunday, July 21, 2019 8:30 PM
To: devel@edk2.groups.io; Feng, Bob C
Subject: RE: [edk2-devel] [Patch] BaseTools: Fixed the mis-using strip()
function issue.
Bob:
> --
Bob:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng
> Sent: Sunday, July 21, 2019 11:55 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Feng, Bob C
> Subject: [edk2-devel] [Patch] BaseTools: Fixed the mis-usin
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2003
lstrip(parameter) do the match based on the char
in parameter but not only the whole parameter string.
In GenMake line 1082,
CmdSign.lstrip('/Fo') will strip the '/' or
'F' or 'o' on the left of CmdSign. This is not expected.
This patch is
