Re: [edk2-devel] [Patch 0/2] UefiCpuPkg: Default avoid print.

2019-08-02 Thread Laszlo Ersek
On 08/01/19 23:14, Andrew Fish wrote: > The MpServices API and even the BSP don't apply at runtime, but then > again you can't run code on the APs at runtime. My understanding is that the OS can invoke a runtime service on any processor. Plus, the UEFI spec classifies runtime services into

Re: [edk2-devel] [Patch 0/2] UefiCpuPkg: Default avoid print.

2019-08-01 Thread Laszlo Ersek
On 08/01/19 00:04, Johnson, Michael wrote: > I do not see a downside to making MAX_DEBUG_MESSAGE_LENGTH a fixed at build > PCD.  It's currently #define'd in a variety of places, which in my opinion is > just asking for trouble. A fixed-at-build PCD sounds good to me. (Not ignoring the rest,

Re: [edk2-devel] [Patch 0/2] UefiCpuPkg: Default avoid print.

2019-08-01 Thread Andrew Fish via Groups.Io
> On Aug 1, 2019, at 1:20 PM, Brian J. Johnson wrote: > > On 7/31/19 1:58 PM, Laszlo Ersek wrote: >> On 07/31/19 18:34, Brian J. Johnson wrote: >>> I do wonder if there would be a clean way to let a DebugLib instance >>> itself declare that AP_DEBUG() is safe. That way a platform would >>>

Re: [edk2-devel] [Patch 0/2] UefiCpuPkg: Default avoid print.

2019-08-01 Thread Dong, Eric
Hi Ray, Yes, I will remove debug code in v2 change. I have submitted feature request for new MP safe DebugLib: https://bugzilla.tianocore.org/show_bug.cgi?id=2043. Thanks, Eric > -Original Message- > From: Ni, Ray > Sent: Thursday, August 1, 2019 3:52 PM > To: Dong, Eric ;

Re: [edk2-devel] [Patch 0/2] UefiCpuPkg: Default avoid print.

2019-08-01 Thread Ni, Ray
Eric, My understanding to your patch is you want to avoid printing from AP because some platforms may choose wrong DebugLib instance for the CpuFeaturePei/Dxe driver, which leads to system hang. To make the platform happy and while the value of printing the debug message is less, the solution in

Re: [edk2-devel] [Patch 0/2] UefiCpuPkg: Default avoid print.

2019-07-31 Thread Johnson, Michael
On Wed, Jul 31, 2019 at 11:58 AM, Laszlo Ersek wrote: > > I'm sure I'm misremembering parts of this story (from several years > distance), the moral is that debugging in a multiprocessing environment > may easily require its own dedicated infrastructure. In edk2, we don't > have anything like

Re: [edk2-devel] [Patch 0/2] UefiCpuPkg: Default avoid print.

2019-07-31 Thread Laszlo Ersek
On 07/31/19 18:34, Brian J. Johnson wrote: > I do wonder if there would be a clean way to let a DebugLib instance > itself declare that AP_DEBUG() is safe. That way a platform would > only need to override the DebugLib instance in the DSC file, rather > than both the instance and the PCD. (I

Re: [edk2-devel] [Patch 0/2] UefiCpuPkg: Default avoid print.

2019-07-31 Thread Andrew Fish via Groups.Io
> On Jul 31, 2019, at 9:34 AM, Brian J. Johnson wrote: > > On 7/31/19 7:43 AM, Laszlo Ersek wrote: >> (adding Mike) >> On 07/31/19 09:35, Eric Dong wrote: >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1984 >>> >>> Current debug message brings much restriction for the platform >>>

Re: [edk2-devel] [Patch 0/2] UefiCpuPkg: Default avoid print.

2019-07-31 Thread Brian J. Johnson
On 7/31/19 7:43 AM, Laszlo Ersek wrote: (adding Mike) On 07/31/19 09:35, Eric Dong wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1984 Current debug message brings much restriction for the platform which use this driver. For PEI and DXE phase, platform mush link base DebugLib

Re: [edk2-devel] [Patch 0/2] UefiCpuPkg: Default avoid print.

2019-07-31 Thread Laszlo Ersek
(adding Mike) On 07/31/19 09:35, Eric Dong wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1984 > > Current debug message brings much restriction for the platform > which use this driver. > > For PEI and DXE phase, platform mush link base DebugLib (without > using any pei/dxe

[edk2-devel] [Patch 0/2] UefiCpuPkg: Default avoid print.

2019-07-31 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1984 Current debug message brings much restriction for the platform which use this driver. For PEI and DXE phase, platform mush link base DebugLib (without using any pei/dxe services, even for its dependent libraries). This patch default