Re: [edk2-devel] [Patch 02/11] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions

2019-07-30 Thread Philippe Mathieu-Daudé
anks, > Bob > > -Original Message- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: Monday, July 29, 2019 11:03 PM > To: devel@edk2.groups.io; Feng, Bob C > Cc: Gao, Liming > Subject: Re: [edk2-devel] [Patch 02/11] BaseTools: Split > Workspa

Re: [edk2-devel] [Patch 02/11] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions

2019-07-29 Thread Bob Feng
/11] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions Hi Bob, On 7/29/19 10:44 AM, Bob Feng wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 > > The WorkspaceAutoGen.__InitWorker function is too long, it's hard to > read and understand.

Re: [edk2-devel] [Patch 02/11] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions

2019-07-29 Thread Philippe Mathieu-Daudé
Hi Bob, On 7/29/19 10:44 AM, Bob Feng wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 > > The WorkspaceAutoGen.__InitWorker function is too long, it's hard > to read and understand. > This patch is to separate the __InitWorker into multiple small ones. Patch looks good, however

[edk2-devel] [Patch 02/11] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions

2019-07-29 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 The WorkspaceAutoGen.__InitWorker function is too long, it's hard to read and understand. This patch is to separate the __InitWorker into multiple small ones. Cc: Liming Gao Signed-off-by: Bob Feng ---