Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-10-12 Thread Liming Gao
Jordan: >-Original Message- >From: Justen, Jordan L >Sent: Saturday, October 12, 2019 3:22 AM >To: af...@apple.com; Laszlo Ersek ; >devel@edk2.groups.io; Gao, Liming >Subject: Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove >__inline__ attri

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-10-11 Thread Jordan Justen
Gao, Liming ; devel@edk2.groups.io; > >> af...@apple.com > >> Subject: Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove > >> __inline__ attribute for IO functions > >> > >> On 10/08/19 16:47, Gao, Liming wrote: > >> > >&

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-10-10 Thread Liming Gao
> To: Gao, Liming ; devel@edk2.groups.io; >af...@apple.com >>> Subject: Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: >Remove __inline__ attribute for IO functions >>> >>> On 10/08/19 16:47, Gao, Liming wrote: >>> >>>> [Liming

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-10-10 Thread Laszlo Ersek
Hi Liming, Andrew, On 10/10/19 14:32, Liming Gao wrote: > Laszlo: > >> -Original Message- >> From: Laszlo Ersek >> Sent: Wednesday, October 9, 2019 4:22 AM >> To: Gao, Liming ; devel@edk2.groups.io; af...@apple.com >> Subject: Re: [edk2-devel] [Pa

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-10-10 Thread Liming Gao
Laszlo: > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, October 9, 2019 4:22 AM > To: Gao, Liming ; devel@edk2.groups.io; af...@apple.com > Subject: Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove > __inline__ attribute for IO functions &

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-10-08 Thread Laszlo Ersek
On 10/08/19 16:47, Gao, Liming wrote: > [Liming] I verify GCC5 tool chain. I will verify GCC48/GCC49 and > XCODE5. > > I don’t know the specific reason about __inline__. If there is no > impact on > > other GCC tool chain, I prefer to remove them. > [Liming] This seems the

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-10-08 Thread Liming Gao
From: devel@edk2.groups.io On Behalf Of Andrew Fish via Groups.Io Sent: Tuesday, October 1, 2019 5:12 AM To: devel@edk2.groups.io; ler...@redhat.com Cc: Gao, Liming Subject: Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions On Sep 30

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-09-30 Thread Andrew Fish via Groups.Io
> On Sep 30, 2019, at 3:35 PM, Laszlo Ersek wrote: > > Hi Liming, > > On 09/27/19 09:46, Liming Gao wrote: >> __inline__ attribute will make the functions not be exposed as the >> library interface. It will cause CLANG9 compiler fail. >> >> Signed-off-by: Liming Gao >

Re: [edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-09-30 Thread Laszlo Ersek
Hi Liming, On 09/27/19 09:46, Liming Gao wrote: > __inline__ attribute will make the functions not be exposed as the > library interface. It will cause CLANG9 compiler fail. > > Signed-off-by: Liming Gao > --- > MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 6 -- > 1 file changed, 6

[edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-09-27 Thread Liming Gao
__inline__ attribute will make the functions not be exposed as the library interface. It will cause CLANG9 compiler fail. Signed-off-by: Liming Gao --- MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 6 -- 1 file changed, 6 deletions(-) diff --git